Closed Bug 1182319 Opened 10 years ago Closed 10 years ago

Hard disable Search Activity assist (swipe up) registration for partner test

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42+ wontfix)

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox42 + wontfix

People

(Reporter: nalexander, Unassigned)

References

Details

This ticket tracks disabling the Search Activity assist intent at [1] and producing a build for partners to test. This should be based on mozilla-release. [1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/search/manifests/SearchAndroidManifest_activities.xml.in#9
(In reply to Nick Alexander :nalexander from comment #1) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef8be0e459ef ASSIST removed entirely.
(In reply to Nick Alexander :nalexander from comment #2) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=981f6c3fb636 CATEGORY_DEFAULT removed. I expect this to not help; the category is implicit, I think.
(In reply to Nick Alexander :nalexander from comment #3) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=27f5f0c3353e This is interesting. The relevant code appears to be http://androidxref.com/4.4.4_r1/xref/frameworks/base/services/java/com/android/server/search/SearchManagerService.java#247; if that's correct, then we might be able to use the android:priority ordering to ensure the Google Search listing is the first one found. We'd need to check ours is still an option, though.
Partner testing reveals that both disabling ASSIST and setting android:priority < 0 succeed. Unfortunately, local testing shows that they both have the same effect, which is to disable the assist action entirely! So that solution is out, and we hard-disable ASSIST for this partner build.
Hi Nick, are you still working on this? Do we need to be tracking it or is the issue resolved?
Flags: needinfo?(nalexander)
(In reply to Liz Henry (:lizzard) from comment #10) > Hi Nick, are you still working on this? Do we need to be tracking it or is > the issue resolved? I think we'll call this resolved. The partner build is out the door, and we're not going to build a permanent work-around in right now.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(nalexander)
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.