Closed
Bug 1182363
Opened 9 years ago
Closed 9 years ago
[EME] GMPGetAPI wrongly logs an error when decryptor API is requested
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
A missing 'else' in GMPGetAPI is the cause:
if ( decryptor? ) {...}
if ( audio decoder? ) {...} <-- missing 'else'
else if ( ... ) {...}
else { log error }
Logging is only enabled by modifying some source and recompiling, so it's minor.
|
Assignee | |
Comment 1•9 years ago
|
||
Added missing 'else' to prevent wrong error logging on Windows.
Attachment #8631930 -
Flags: review?(edwin)
Attachment #8631930 -
Flags: review?(edwin) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a06120b1fcb
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2e42de2a4643
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•