Fix fallout from bug 905127 due to missing headers for purplexpcom

RESOLVED FIXED in 1.6

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

trunk
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
Some bustages in purpleAccount and purpleProtocol due to bug 905127.

I've attached a patch which gets purplexpcom to compile, but it does not link:

 0:19.87 Undefined symbols for architecture x86_64:
 0:19.87   "NS_NewFileURI(nsIURI**, nsIFile*, nsIIOService*)", referenced from:
 0:19.87       purpleAccountBuddy::GetBuddyIconFilename(nsACString&) in purpleAccountBuddy.o
 0:19.87   "NS_IsOffline()", referenced from:
 0:19.87       purpleAccount::Connect() in purpleAccount.o
 0:19.87       purpleDNS::Resolve(_PurpleDnsQueryData*, void (*)(_PurpleDnsQueryData*, _GSList*), void (*)(_PurpleDnsQueryData*, char const*)) in purpleDNS.o
 0:19.87       purpleSocketWatcher::AddWatch(int, PurpleInputCondition, void (*)(void*, int, PurpleInputCondition), void*) in purpleSockets.o
 0:19.87 ld: symbol(s) not found for architecture x86_64
 0:19.87 clang: error: linker command failed with exit code 1 (use -v to see invocation)
 0:19.87 make[4]: *** [libpurplexpcom.dylib] Error 1
 0:19.87 make[3]: *** [extensions/purple/purplexpcom/src/target] Error 2
 0:19.87 make[2]: *** [compile] Error 2
 0:19.87 make[1]: *** [compile] Error 2
 0:19.87 make: *** [default] Error 2
Attachment #8631940 - Flags: review?(florian)

Comment 1

4 years ago
Maybe comment 18 - 25 in bug 905127 help with the linking?
Assignee

Comment 2

4 years ago
(In reply to aleth [:aleth] from comment #1)
> Maybe comment 18 - 25 in bug 905127 help with the linking?

Hmm...so there is this nsNetUtil.inl file, but it doesn't seem to include NS_IsOffline or NS_NewFileURI, which are the functions that we need...maybe I need to define some external linkage thing?

Comment 3

4 years ago
(In reply to Patrick Cloke [:clokep] from comment #2)
> (In reply to aleth [:aleth] from comment #1)
> > Maybe comment 18 - 25 in bug 905127 help with the linking?
> 
> Hmm...so there is this nsNetUtil.inl file, but it doesn't seem to include
> NS_IsOffline or NS_NewFileURI, which are the functions that we need...maybe
> I need to define some external linkage thing?

Since "The functions that need to be seen by external code or that change their behavior when used by external code are contained in nsNetUtil.inl." I guess what's needed is to get those two functions added there.
Assignee

Comment 4

4 years ago
Florian suggested on IRC:
11:11:08 AM - flo-retina: clokep_work: if NS_NewFileURI turns out to be a pain, it's trivial to inline in our code: http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsNetUtil.cpp#120
11:11:45 AM - flo-retina: NS_IsOffline is easy too: http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsNetUtil.cpp#1404
Depends on: 1183579
Attachment #8631940 - Flags: review?(florian) → review+
Assignee

Comment 5

4 years ago
http://hg.mozilla.org/users/florian_queze.net/purple/rev/21c486b08dda

We should still be busted after this...
Flags: needinfo?(dd.mozilla)
Have added patch from bug 1183579, it isn't in mozilla central jet. if you have applied the patch, can you tell me how to build purplexpcom from mozilla central.
Flags: needinfo?(dd.mozilla)
Assignee

Comment 7

4 years ago
Dragana, Florian applied the patch this morning and it worked fine for him. Thanks for fixing this! :)
Assignee: nobody → clokep
Target Milestone: --- → 1.6
(In reply to Patrick Cloke [:clokep] from comment #7)
> Dragana, Florian applied the patch this morning and it worked fine for him.
> Thanks for fixing this! :)

I actually verified the patch fixes the compile issue on both Linux and Mac.
Assignee

Comment 9

4 years ago
This should be fixed now!
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.