1182378 - Building with ASan on Mac: Undefined symbol "___lsan_ignore_object"

Status: RESOLVED WORKSFORME

(Core :: MFBT, defect)

Description

[Jesse Ruderman]

Attachment: build log

Setup:
* Mac
* mozilla-central rev 2c91d57441fd (trunk from today)
* LLVM rev r241643 (trunk from yesterday)
* mozconfig with "-fsanitize=address" in {CC,CXX} as well as {CFLAGS,CXXFLAGS,LDFLAGS} to work around an NSS build issue

> Undefined symbols for architecture x86_64:
>   "___lsan_ignore_object", referenced from:
>       mozilla::nsTerminator::StartWriter() in nsTerminator.o
>       mozilla::(anonymous namespace)::RunWriter(void*) in nsTerminator.o
>       mozilla::nsTerminator::Observe(nsISupports*, char const*, char16_t const*) in nsTerminator.o
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see invocation)

The macro that calls __lsan_ignore_object was added in bug 1075134.

Comment 1

[Jesse Ruderman]

Attachment: mozconfig-asan

Comment 2

[Jesse Ruderman]

If I work around this by making MOZ_LSAN_INTENTIONALLY_LEAK_OBJECT a no-op, my build succeeds. Somehow the __asan_* symbols are linking fine and only the __lsan_* symbol is having trouble.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

I just pulled the latest compiler-rt, and __lsan_ignore_object seems still present in compiler-rt//lib/lsan/lsan_common.cc. It doesn't seem #ifdefed away.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 5

[Mike Hommey [:glandium]]

AFAICT, ASan builds work on mac and have for a while. Let's call this WFM.