1182395 - -P without an argument broken in Firefox 39, Ubuntu 14.04

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[GAJ]

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.132 Safari/537.36

Steps to reproduce:

launching firefox profile manager from terminal using
  firefox -P


Actual results:

profile manager does not start
Error message:
(process:30334): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
Error: argument -p requires a profile name



Expected results:

when launching the firefox profile manager without specifying a profile, the profile  manager window should open, allowing to choose from previously created profiles

Comment 1

[Alice0775 White]

Steps to reproduce:
1. Extract from .tar.bz2 to a folder
2. Launch terminal and cd the folder
3. ./firefox -P


Actual Results:
Error: argument -p requires a profile name

Expected Results:
Profile Manager should start


Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5ddbdbc00f3c&tochange=f1902c4276e1

Regressed by:
f1902c4276e1	Mike Hommey — Bug 486172 - Don't ignore a -p command line argument when using the Xremote protocol. r=bsmedberg

Comment 2

[Kate Glazko]

Tracking because regression.

Comment 3

[Benjamin Smedberg]

Presumably -profilemanager still works, right?

Comment 4

[Alice0775 White]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> Presumably -profilemanager still works, right?

Indeed, it works properly.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Don't error out when -p is not given an argument in RemoteCommandLine

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d28c3add8df3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d28c3add8df3

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

This looks like a pretty simple change. 40 and 41 are marked as affected. What do you think about uplifting to Beta and Aurora?

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 8633833 [details] [diff] [review]
Don't error out when -p is not given an argument in RemoteCommandLine

Approval Request Comment
[Feature/regressing bug #]: Regression from bug 486172.
[User impact if declined]: firefox -P doesn't work anymore to display the profile manager
[Describe test coverage new/current, TreeHerder]: There is no automated test for this. Without the patch, firefox -P prints out "Error: argument -p requires a profile name". With the patch, firefox -P opens the profile manager, like it used to up to and including Firefox 38.
[Risks and why]: Low. The patch replaces the output of an error message with a fall-through to the old behavior.
[String/UUID change made/needed]: None

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8633833 [details] [diff] [review]
Don't error out when -p is not given an argument in RemoteCommandLine

Beta+ Aurora+

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c4f8219f3ea3

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4bd34b79aa11

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Reproduced the original issue using steps from comment 1, on Ubuntu 12.04 x86, using Firefox 40 Beta 6. The issue no longer reproduces in the latest Firefox 42 Nightly. "./firefox-bin -p" now correctly launches the Profile Manager. Using additional parameters like the profile name or -no-remote also seems to still work fine.

Marking verified for Nightly 42, and setting [good first verify] in case our contributors want to verify on Beta 40 or Aurora 41.

Comment 14

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced the bug in Nightly 42.0a1 (2015-07-09) on Linux (Ubuntu 14.04) x64 with the comment 1's instruction!

This Bug is now verified as fixed on Latest Firefox Beta 40.0b7 (BUild ID: 20150723165742) and

Latest Aurora 41.0a2 (2015-07-25) (Build ID: 20150725004004)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0

Comment 16

[Rakibul Islam Ratul]

As per comment 14, changing the status as verified..