11824 - :-moz-drag-over doesn't work on chrome

Status: RESOLVED WONTFIX

(Core :: XUL, defect, P4)

Description

[Mike Pinkerton (not reading bugmail)]

make sure rod hooked up :drag-over correctly. I don't think he did, but i could
be reading the code incorrectly.

Comment 1

[Mike Pinkerton (not reading bugmail)]

m10.

Comment 2

[Peter Trudelle]

reassigning to pink for m14

Comment 3

[Mike Pinkerton (not reading bugmail)]

accepting

Comment 4

[Mike Pinkerton (not reading bugmail)]

moving dogfood-related d&d stuff back to M12. woohoo!

Comment 5

[Peter Trudelle]

mass-moving all m12 bugs to m13

Comment 6

[Paul MacQuiddy]

dividing up phillips qa contact bugs, he no longer works here

Comment 7

[Peter Trudelle]

drag&drop is once again post-beta according to marketing. moving all d&d bugs to
M15.

Comment 8

[Mike Pinkerton (not reading bugmail)]

not essential.

Comment 9

[Peter Trudelle]

Mass moving M17 bugs to M18

Comment 10

[Peter Trudelle]

mass-moving all bugs to m21 that are not dofood+, or nsbeta2+

Comment 11

[Mike Pinkerton (not reading bugmail)]

all the code appears to be written, but for some reason the state isn't always
being set in the ESM. we only set it when the handling of the dom event !=
consumeNoDefault, which is never the case when we're over the chrome for drag
events.

a good testcase of this is to change ben's rules for the home button in
  mozilla/themes/modern/communicator/button.css
to use :drag-over instead of having the JS set an attribute.

cc'ing saari.

Comment 12

[Peter Trudelle]

adding nsbeta3+  -- part of basic toolkit functionality 

Comment 13

[Mike Pinkerton (not reading bugmail)]

alas, I don't think i'll be able to get to this. futuring.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

-> me for investigation

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

Boy do I suck. Accepting. I'll get to this some day. 

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Mass reassign of my non-Firefox bugs to [e-mail]

Comment 17

[Nochum Sossonko [:Natch]]

psuedo class was renamed to -moz-drag-over, but still doesn't work on chrome afaict.

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The check that pink mentioned in comment 11 is still in nsEventStateManager::FireDragEnterOrExit .

I also think :-moz-drag-over should probably be hierarchical just like :active and :hover.  (This involves changing nsEventStateManager::GetContentState and nsEventStateManager::SetContentState.)

We might also want to make sure that nsEventStateManager::GenerateDragDropEnterExit makes sense.

Comment 19

[Ian Nartowicz]

Apparently works on chrome now, at least for me.  Are there also cases where it doesn't work?

Comment 18 still applies though.  This selector is useless as currently implemented, due to not selecting when dragging over anonymous children (or any other children for that matter).  Perhaps this is masking the fact that it actually does work in its own limited fashion?

Comment 20

[Axel Grude [:realRaven]]

It doesn't appear to work for background-image (at least when using a gradient), and the same applies in Postbox. Can be tested by using QuickFolders and setting a palette entry for the drag over style.

Comment 21

[Axel Grude [:realRaven]]

(In reply to Axel Grude [:realRaven] from comment #20)
> It doesn't appear to work for background-image (at least when using a
> gradient), and the same applies in Postbox. Can be tested by using
> QuickFolders and setting a palette entry for the drag over style.

Sorry. to be more precise: it works in Thunderbird (chrome) but not in SeaMonkey and Postbox (chrome). I am adding the dragover rules dynamically.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72bb988bcbb1
[fenix] Add tests for ContextKt (https://github.com/mozilla-mobile/fenix/pull/11824)

Comment 23

[Sylvestre Ledru [:Sylvestre]]

XUL + no activity for a while. Closing.