1182440 - Edited context does not update on the standalone page (link clicker)

Status: RESOLVED INVALID

(Hello (Loop) :: Client, enhancement, P4)

Description

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Reproducible with: 
- Firefox 40 Beta 3 - BuildID: 20150709163524
- Firefox 40 Beta 2 - BuildID: 20150706172413

Reproducible on: Windows 7 x64, Windows 10 x86, Mac OS X 10.8.5

Steps to reproduce:
1. On one machine (machine A) open Firefox with a fresh profile and navigate to a web page.
2. Click on the Hello icon and then "Get Started".
3. Check "Let's talk about" -> "Start a conversation".
4. Copy the conversation link and open it on another machine (machine B) and join the conversation.
5. On machine A choose to edit the conversation context (pen icon overlayed on the video area) and then save.

Expected results:
User on machine B should see the changes made to the context on machine A in (close to) real time.

Actual results:
User on machine B does not see the changes made to the context on machine A unless he/she leaves and then re-joins the conversation.

I'm not sure whether this ever worked, is planned to be implemented, or if it's some server issue, but it should definitely work as otherwise the Edit context option makes no sense.

Comment 1

[Mike de Boer [:mikedeboer]]

Well, this has never worked really, because the standalone page does not have a persistent connection to get push notifications in.
Now that we have a p2p datachannel opened up for text chat, we can (ab)use it to push these type of changes over as well as text messages.

Comment 2

[Robert Kaiser]

[Tracking Requested - why for this release]:
Nominating Hello Conversation Context issues for 40, as the amount of issues makes the feature questionable for release with this train.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This scenario seems fairly common and it would be nice to get a fix for this in time for FF40 release.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Maire, could you please review this bug? This seems like a mainline scenario that should be working given that hello context is releasing as a new feature in FF40. Thanks!

Comment 5

[Maire Reavy [:mreavy]]

Hi Ritu, I'm no longer the engineering manager for Hello. (I'm the engineering manager for WebRTC.)  I don't believe we currently have an eng manager for Hello; so I'm moving my needinfo to Shell to get the right Hello folks weighing in on this (especially with Mark Banner on PTO this week).

Comment 6

[Romain Testard [:RT]]

This works as expected.
The typical user scenario that are anticipated are that either A updates the context before inviting B or A updates the context after A and B have had a conversation so that next time they talk about something different (i.e update the context and then share again).

The scenario described above is valid but was not required to be supported for Fx40.
Let's keep this bug as a feature improvement to make context changes dynamic but this was not a requirement for Fx40 so should not be blocking the release.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Un-tracked for FF40 and tracking for 41, 42 instead based on Romain's assessment which makes sense.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Mark, this is another one that is tracked for FF41. Do you think we will be able to get a patch ready by Beta6/7 time frame? My opinion on this one is if it is an easy fix, we could take it. Otherwise, given the low severity this can be fixed in 42. What do you think?

Comment 9

[Mark Banner (:standard8)]

(In reply to Ritu Kothari (:ritu) from comment #8)
> Mark, this is another one that is tracked for FF41. Do you think we will be
> able to get a patch ready by Beta6/7 time frame? My opinion on this one is
> if it is an easy fix, we could take it. Otherwise, given the low severity
> this can be fixed in 42. What do you think?

I wouldn't rush this in 41, whilst it wouldn't be a big change, with the other work, and what I feel is the priority, I don't think it is worth it. Personally I don't think its a huge issue, I suspect users are more likely just to put a url in the chat if they are already in a call than go to the trouble of editing the context.

Its also been rumored that we're going to change how context works, so it might be better to wait for that.

However, I'm passing the needinfo to Romain to check he's happy with this.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

In line with Mark's recommendation, I do not feel this is a release blocker for FF41 so removing the tracking flag and setting status-firefox41 to wontfix. Romain, please let me know if you have any concerns.

Comment 11

[Romain Testard [:RT]]

I agree with Mark's comment, this should not block 41.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

We shipped two releases with this bug, stop tracking.

Comment 13

[Ian Bicking (:ianbicking)]

We've removed context editing so this bug no longer applies to the product