1182641 - Convert ANRReporter to new JNI scheme

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Use the new autogenerated JNI stubs for ANRReporter

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use new autogenerated native methods for ANRReporter (v1)

Switch from using mozglue stubs to using direct native functions.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1182641 - Update autogenerated code; r=me

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Implement new native methods for ANRReporter (v1)

Move the native implementation from AndroidJNI.cpp to ANRReporter.cpp

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8637281 [details] [diff] [review]
Implement new native methods for ANRReporter (v1)

Review of attachment 8637281 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/ANRReporter.cpp
@@ +10,5 @@
> +
> +namespace mozilla {
> +
> +bool
> +ANRReporter::RequestNativeStack(bool aUnwind)

I'm assuming everything in here is copy/pasted from AndroidJNI?

::: widget/android/AndroidBridge.cpp
@@ +250,5 @@
>      jClose = inputStream.getMethod("close", "()V");
>      jAvailable = inputStream.getMethod("available", "()I");
>  
>      InitAndroidJavaWrappers(jEnv);
> +    ANRReporter::Init();

Any idea what kind of impact this has on startup?

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #4)
> Comment on attachment 8637281 [details] [diff] [review]
> Implement new native methods for ANRReporter (v1)
> 
> ::: widget/android/ANRReporter.cpp
> @@ +10,5 @@
> > +
> > +namespace mozilla {
> > +
> > +bool
> > +ANRReporter::RequestNativeStack(bool aUnwind)
> 
> I'm assuming everything in here is copy/pasted from AndroidJNI?

Yep!

> ::: widget/android/AndroidBridge.cpp
> @@ +250,5 @@
> >      jClose = inputStream.getMethod("close", "()V");
> >      jAvailable = inputStream.getMethod("available", "()I");
> >  
> >      InitAndroidJavaWrappers(jEnv);
> > +    ANRReporter::Init();
> 
> Any idea what kind of impact this has on startup?

Should be very small. ANRReporter::Init just registers JNI calls through JNIEnv::RegisterNatives. We also saved some time by not trying to find these libxul symbols in mozglue.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/572e4ffbc46d
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b135e6cfe07
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8758fe033b9

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/572e4ffbc46d
https://hg.mozilla.org/mozilla-central/rev/3b135e6cfe07
https://hg.mozilla.org/mozilla-central/rev/f8758fe033b9