1182648 - Bug report rejected when assignee has a trailing comma

Status: NEW

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Jesse Ruderman]

Bugzilla should accept trailing commas in the assignee field when submitting a new bug report. Currently, it rejects the field as having "no matches".

Here's how I ended up a trailing comma:
  1. Typed "sphink" in CC field
  2. Tab completed to the complete email address, plus a comma
  3. Realized I want to assign the bug to him, not just CC him
  4. Cut-and-pasted to assignee field

Comment 1

[Frédéric Buclin]

I see one minor problem with your proposal. Assume that a realname (as opposed to the login name, a.k.a email address) contains a string of the form:

  "Firstname Name (do not use [e-mail], use this account instead)"

Now let's consider that I type "[e-mail]," (with the trailing comma) in the assignee field. Then removing the trailing comma would automatically make Bugzilla find and return "[e-mail]" as the single result, because this email address exactly matches the "sanitized" string, and Bugzilla won't look further (that's the desired behavior). If we don't remove the trailing comma, then Bugzilla won't find a match in email addresses (because commas are illegal in email addresses) and will then look at the realname and will find the other account.

If we ignore this edge case, it's trivial to fix. It's a one-liner in Bugzilla::User::match_field(). Else it's a headache and prone to other edge cases.

Comment 2

[Jesse Ruderman]

Please ignore that edge case. Nobody tries to match on that kind of substring, and doing so already doesn't work in the CC field.