1182744 - Make MaskLayerImageKey::mLayerCount and its mutators private

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make MaskLayerImageKey::mLayerCount and its mutators private

As requested, this patch makes mLayerCount and it's mutators private, and exposes only a HasZeroLayerCount method. The way to manage mLayerCount under this system is to use MaskLayerImageKeyRef, which is now a friend class of MaskLayerImageKey.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Michael Layzell [:mystor] from comment #1)
> As requested

(in bug 1073219 comment 13, for reference)

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8632403 [details] [diff] [review]
Make MaskLayerImageKey::mLayerCount and its mutators private

Looks good to me! Thanks for keeping the constructor init-lists in order, too. :)

Comment 4

[Daniel Holbert [:dholbert]]

(Technically "Layer"-flavored files in the layout/ directory belong in bugzilla-component "Graphics::Layers". --> reclassifying.)

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Please land after bug 1073219

Comment 6

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46afc1f50209

Comment 7

[Daniel Holbert [:dholbert]]

Added bug number and "r=dholbert" to commit message (please include those up-front in the future; sorry for not mentioning that in review comments), and landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e50aeaca001a

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e50aeaca001a