Closed Bug 1182804 Opened 9 years ago Closed 6 years ago

Tapping or text selection near a link does not take zooming into account

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
39 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec+)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
fennec + ---

People

(Reporter: nicolae_albu2004, Unassigned)

References

(
URL
)

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150525141253

Steps to reproduce:

Scenario 1:
1. Go to a page that has a link and something "clickable" next to it that is not a <a href> or a button. For example, a <div> or an image with handlers.
2. Zoom in to the maximum so touching the clickable item with the finger does not reach the link.
3. Tap on the clickable item.

Scenario 2:
1. Go to a page that has a link and some text next to it.
2. Zoom in to the maximum so touching the text with the finger does not reach the link.
3. Tap and hold on the text with the intention of copying the text.


Actual results:

Scenario 1:
The link is triggered instead of the clickable item, although there is a distance of like 1 cm between where I tapped and the link. I recorded the behavior here: https://youtu.be/bk2kMNXHDL8 .

Scenario 2:
The tap and hold is triggered on the link (opening the link context menu) instead of the text (selecting the text). I will upload a video of this too if it helps.


Expected results:

Scenario 1:
The clickable item should have been triggered instead of the link.

Scenario 2:
The text should have been selected instead of opening the context menu of the nearby link.

The feature that triggers links when tapping near them should take zooming into account. In my video, I tapped something that was over 1 cm further from the link and the link was triggered.
URL: https://youtu.be/bk2kMNXHDL8
OS: Unspecified → Android
Hardware: Unspecified → ARM
Snorp, any idea what's going on here?
Flags: needinfo?(snorp)
I think the "tap near link / button helper" uses page pixels / points (at scale 1) instead of display pixels (when zooming, the distance in pixels is way larger).
This results in a big usability problem. This problem is encountered even on a 10 inch tablet, where the distance between the finger and the link / button is ridiculously large...
Let's reevaluate this one after native APZ has landed.
tracking-fennec: ? → +
Flags: needinfo?(snorp) → needinfo?(rbarker)
¡Hola Nicolae!

Is this still a problem on Nightly from https://nightly.mozilla.org/ ?

AFAIK the "native APZ" mentions has landed recently.

¡Gracias!
Flags: needinfo?(nicolae_albu2004)
Yes, still a problem on today's nightly...
Do I have to enable something in about:config?
Flags: needinfo?(nicolae_albu2004)
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #3)
> Let's reevaluate this one after native APZ has landed.

I went to the page in the youtube video and was unable to reproduce the issue in nightly.
Flags: needinfo?(rbarker)
I'll try again using latest nightly.
It's way better (meaning usable at all vs unusable) in nightly than in stable, though it still doesn't compare with other browsers.
In Firefox I still need a large amount of zoom to prevent activating the link from above the button.
In Opera, for example, I don't need to zoom at all.
(In reply to Nicolae Albu from comment #8)
> It's way better (meaning usable at all vs unusable) in nightly than in
> stable, though it still doesn't compare with other browsers.
> In Firefox I still need a large amount of zoom to prevent activating the
> link from above the button.
> In Opera, for example, I don't need to zoom at all.

I think this and Bug 1233272 are probably the same issue. We definitely seem to have a hit test issue when links are close to selectable non-links. This may have been by design but the current implementation feels too aggressive in favoring links over other selectable items.
Hi,

I was not able to reproduce the issue.

Tested with:
Browser / Version: Firefox Mobile Nightly 63.0a1 (2018-08-07)
Operating System: Sony Xperia Z5 Premium (Android 6.0.1)

Could you download the latest Nightly and retry?

Thank you!
Flags: needinfo?(nicolae_albu2004)
I cannot reproduce it anymore, even in stable (61.0).
Flags: needinfo?(nicolae_albu2004)
Taking into consideration Comment 11, I will close this issue as Works for me.
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.