Closed Bug 1182826 Opened 8 years ago Closed 8 years ago

Handle failing assignment in DataStoreDB::Open

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: poiru, Assigned: poiru)

References

Details

Attachments

(1 file)

Handle failing assignment in DataStoreDB::Open
Oops, bzexport fail.
Summary: imported patch DataStoreDB-assign.patch → Handle failing assignment in DataStoreDB::Open
Comment on attachment 8632490 [details] [diff] [review]
Handle failing assignment in DataStoreDB::Open

An alternative solution is to make this infallible after bug 968520 is done.
Attachment #8632490 - Attachment description: imported patch DataStoreDB-assign.patch → Handle failing assignment in DataStoreDB::Open
Attachment #8632490 - Flags: review?(amarchesini)
Blocks: 968520
Comment on attachment 8632490 [details] [diff] [review]
Handle failing assignment in DataStoreDB::Open

Review of attachment 8632490 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/datastore/DataStoreDB.cpp
@@ +146,5 @@
>  {
>    MOZ_ASSERT(mState == Inactive);
>  
> +  Sequence<nsString> objectStores;
> +  if (!objectStores.Assign(aDbs, fallible)) {

I prefer to wait for bug 968520.
Attachment #8632490 - Flags: review?(amarchesini)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Resolution: FIXED → WONTFIX
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.