Closed
Bug 1182826
Opened 9 years ago
Closed 9 years ago
Handle failing assignment in DataStoreDB::Open
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: poiru, Assigned: poiru)
References
Details
Attachments
(1 file)
1.39 KB,
patch
|
Details | Diff | Splinter Review |
Handle failing assignment in DataStoreDB::Open
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Oops, bzexport fail.
Summary: imported patch DataStoreDB-assign.patch → Handle failing assignment in DataStoreDB::Open
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8632490 [details] [diff] [review]
Handle failing assignment in DataStoreDB::Open
An alternative solution is to make this infallible after bug 968520 is done.
Attachment #8632490 -
Attachment description: imported patch DataStoreDB-assign.patch → Handle failing assignment in DataStoreDB::Open
Attachment #8632490 -
Flags: review?(amarchesini)
Comment 4•9 years ago
|
||
Comment on attachment 8632490 [details] [diff] [review]
Handle failing assignment in DataStoreDB::Open
Review of attachment 8632490 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/datastore/DataStoreDB.cpp
@@ +146,5 @@
> {
> MOZ_ASSERT(mState == Inactive);
>
> + Sequence<nsString> objectStores;
> + if (!objectStores.Assign(aDbs, fallible)) {
I prefer to wait for bug 968520.
Attachment #8632490 -
Flags: review?(amarchesini)
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Resolution: FIXED → WONTFIX
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•