1182918 - Add telemetry for "double press" action in Tab Queues

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

For V1, Martyn added a time-based "window" within which, a user can press a link > launch tab queues toast > press the same link again > and simply launch Firefox.

This was intended to help alleviate some concerns around UX (bug 1159296).

This bug is to add telemetry for that "double press" action.

I want to see if we could possibly leverage this interaction in the future to help improve Tab queues so we should get some measure of it.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Currently this is counted as "tabqueue-now". So double-tapping as well as clicking the "open now" button are referred to as "tabqueue-now".

I'll split them into two events. However it's worth noting that we do not mention the double-tap behavior anywhere. So we'll only count people who somehow uncovered it or who just accidentally double-clicked a link.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle

Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

This patch splits the two actions into two events:
* tabqueue-doubletap
* tabqueue-now

I'm not sure if we need to do more than defining the new event in code?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8679352 [details]
MozReview Request: Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle

https://reviewboard.mozilla.org/r/23407/#review20899

Looks fine to me. Try to uplift this to Aurora too.

My only worry about these sort of changes is making sure that no code path is left without a probe. This patch seems to cover all the existing code paths.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/f222336ab85f4940fd649cf7009d712cca9b3753
Bug 1182918 - Tab Queue: Add telemetry for double tap action. r=mfinkle

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8679352 [details]
MozReview Request: Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle

Approval Request Comment

[Feature/regressing bug #]: Just adding better, more exact telemetry to new tab queue feature.

[User impact if declined]: None

[Describe test coverage new/current, TreeHerder]: -

[Risks and why]: Low - just adding different/new telemetry.

[String/UUID change made/needed]: -

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f222336ab85f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f222336ab85f

Comment 9

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8679352 [details]
MozReview Request: Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle

Telemetry change, should be safe.
Should be in 43 beta 2.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/90fd79bb1f20

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee8a828b4974

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/90fd79bb1f20