Closed Bug 1182918 Opened 4 years ago Closed 4 years ago

Add telemetry for "double press" action in Tab Queues

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: antlam, Assigned: sebastian)

References

Details

Attachments

(1 file)

For V1, Martyn added a time-based "window" within which, a user can press a link > launch tab queues toast > press the same link again > and simply launch Firefox.

This was intended to help alleviate some concerns around UX (bug 1159296).

This bug is to add telemetry for that "double press" action.

I want to see if we could possibly leverage this interaction in the future to help improve Tab queues so we should get some measure of it.
Assignee: nobody → s.kaspari
Currently this is counted as "tabqueue-now". So double-tapping as well as clicking the "open now" button are referred to as "tabqueue-now".

I'll split them into two events. However it's worth noting that we do not mention the double-tap behavior anywhere. So we'll only count people who somehow uncovered it or who just accidentally double-clicked a link.
Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle
Attachment #8679352 - Flags: review?(mark.finkle)
This patch splits the two actions into two events:
* tabqueue-doubletap
* tabqueue-now

I'm not sure if we need to do more than defining the new event in code?
Comment on attachment 8679352 [details]
MozReview Request: Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle

https://reviewboard.mozilla.org/r/23407/#review20899

Looks fine to me. Try to uplift this to Aurora too.

My only worry about these sort of changes is making sure that no code path is left without a probe. This patch seems to cover all the existing code paths.
Attachment #8679352 - Flags: review?(mark.finkle) → review+
Comment on attachment 8679352 [details]
MozReview Request: Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle

Approval Request Comment

[Feature/regressing bug #]: Just adding better, more exact telemetry to new tab queue feature.

[User impact if declined]: None

[Describe test coverage new/current, TreeHerder]: -

[Risks and why]: Low - just adding different/new telemetry.

[String/UUID change made/needed]: -
Attachment #8679352 - Flags: approval-mozilla-beta?
Attachment #8679352 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f222336ab85f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Comment on attachment 8679352 [details]
MozReview Request: Bug 1182918 - Tab Queue: Add telemetry for double tap action. r?mfinkle

Telemetry change, should be safe.
Should be in 43 beta 2.
Attachment #8679352 - Flags: approval-mozilla-beta?
Attachment #8679352 - Flags: approval-mozilla-beta+
Attachment #8679352 - Flags: approval-mozilla-aurora?
Attachment #8679352 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.