1182933 - New MediaResource::SilentReadAt not always restoring state properly

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Bug 1175768 implemented the method MediaResource::SilentReadAt ; however under some circumstances the stream position isn't always restored to what it was.

Additionally, the MediaByteBuffer returned always has a length of 0.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Implement MediaReadAt.

Ensure SilentReadAt seek back to original position even in case of error.
Properly set the MediaByteBuffer length.

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8632601 [details] [diff] [review]
Implement MediaReadAt.

Carrying r+ from bug 1148102.

Comment 3

[Jean-Yves Avenard [:jya]]

Taking the patch from bug 1148102 as this needs to be uplifted.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76b77a5ace93

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8632601 [details] [diff] [review]
Implement MediaReadAt.

Approval Request Comment
[Feature/regressing bug #]: 1175768
[User impact if declined]: Assertion under special circumstances.
[Describe test coverage new/current, TreeHerder]: Been using this patch locally for over 2 weeks.
[Risks and why]: Low, only fixing incorrect behaviour
[String/UUID change made/needed]: None

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76b77a5ace93

Comment 7

[Seth Fowler [:seth] [:s2h]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d22e1a5af66b

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8632601 [details] [diff] [review]
Implement MediaReadAt.

Based on dev's verification and the fact that the patch has been in nightly for a few days, let's uplift to Aurora.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/414e93c84fe3