1183129 - Remove a dead iOS-related conditional from configure.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

This conditional isn't actually useful, and for some reason it's breaking my Mac cross builds (I don't know why, but it seems easier to just remove the conditional than sort that out, honestly.)

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1183129 - Remove a dead iOS-related conditional from configure.in. r?glandium

bug 1183129 - Remove a dead iOS-related conditional from configure.in. r?glandium

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8632809 [details]
MozReview Request: bug 1183129 - Remove a dead iOS-related conditional from configure.in. r?glandium

https://reviewboard.mozilla.org/r/13137/#review11777

::: configure.in
(Diff revision 1)
> -    if test "$MOZ_WIDGET_TOOLKIT" == "cocoa"; then

I'm not too thrilled removing something that clearly changes the build options on ios, while I bet your problem is that your /bin/sh is not bash and that this line is a bashism. Replace == with =.

Comment 3

[(not currently active) Ted Mielczarek]

I did finally come to the same conclusion (bashism), but this doesn't change the build options on iOS, hence why I said it's dead code. iOS uses the cairo-uikit case right below that:
https://dxr.mozilla.org/mozilla-central/source/configure.in#4345

I think that's leftover from an earlier time when that case didn't exist.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8632809 [details]
MozReview Request: bug 1183129 - Remove a dead iOS-related conditional from configure.in. r?glandium

https://reviewboard.mozilla.org/r/13137/#review11877

Ship It!

Comment 5

[Mike Hommey [:glandium]]

And this is where actually reading the patch context helps.

Comment 6

[(not currently active) Ted Mielczarek]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2ae1d5ecc1fbc70298362e5b94c03c4fc00d43b7
changeset:  2ae1d5ecc1fbc70298362e5b94c03c4fc00d43b7
user:       Ted Mielczarek <[e-mail]>
date:       Mon Jul 13 07:20:30 2015 -0400
description:
bug 1183129 - Remove a dead iOS-related conditional from configure.in. r=glandium

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ae1d5ecc1fb