Remove a dead iOS-related conditional from configure.in

RESOLVED FIXED in Firefox 42

Status

Firefox Build System
General
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla42

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This conditional isn't actually useful, and for some reason it's breaking my Mac cross builds (I don't know why, but it seems easier to just remove the conditional than sort that out, honestly.)
Created attachment 8632809 [details]
MozReview Request: bug 1183129 - Remove a dead iOS-related conditional from configure.in. r?glandium

bug 1183129 - Remove a dead iOS-related conditional from configure.in. r?glandium
Attachment #8632809 - Flags: review?(mh+mozilla)
Comment on attachment 8632809 [details]
MozReview Request: bug 1183129 - Remove a dead iOS-related conditional from configure.in. r?glandium

https://reviewboard.mozilla.org/r/13137/#review11777

::: configure.in
(Diff revision 1)
> -    if test "$MOZ_WIDGET_TOOLKIT" == "cocoa"; then

I'm not too thrilled removing something that clearly changes the build options on ios, while I bet your problem is that your /bin/sh is not bash and that this line is a bashism. Replace == with =.
Attachment #8632809 - Flags: review?(mh+mozilla)
I did finally come to the same conclusion (bashism), but this doesn't change the build options on iOS, hence why I said it's dead code. iOS uses the cairo-uikit case right below that:
https://dxr.mozilla.org/mozilla-central/source/configure.in#4345

I think that's leftover from an earlier time when that case didn't exist.
Comment on attachment 8632809 [details]
MozReview Request: bug 1183129 - Remove a dead iOS-related conditional from configure.in. r?glandium

https://reviewboard.mozilla.org/r/13137/#review11877

Ship It!
Attachment #8632809 - Flags: review+
And this is where actually reading the patch context helps.
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2ae1d5ecc1fbc70298362e5b94c03c4fc00d43b7
changeset:  2ae1d5ecc1fbc70298362e5b94c03c4fc00d43b7
user:       Ted Mielczarek <ted@mielczarek.org>
date:       Mon Jul 13 07:20:30 2015 -0400
description:
bug 1183129 - Remove a dead iOS-related conditional from configure.in. r=glandium
https://hg.mozilla.org/mozilla-central/rev/2ae1d5ecc1fb
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.