1183166 - Provide 'Open In' when viewing PDF's

Status: RESOLVED FIXED

(Firefox for iOS :: General, enhancement)

Description

[Bill Walker [:bwalker] [@wfwalker]]

As a Firefox for iOS user, when I'm viewing a PDF I want to be able to "open in iBooks" so I can save the PDF and access it later.

Comment 1

[Aaron Train [:aaronmt]]

Not sure if there's a public API. Related (?) solution (?) at http://stackoverflow.com/questions/29631293/how-do-i-load-a-webview-page-with-a-pdf-into-ibooks-using-swift?rq=1

Comment 2

[Aaron Train [:aaronmt]]

Seen again on ios-feedback https://groups.google.com/a/mozilla.com/d/msg/ios-mobile-testers/gpo6BOx24W8/Zp4gjGQkQQcJ

Comment 3

[Richard Newman [:rnewman]]

tracking? so we can get a quick technical investigation and consider aiming for a release.

Comment 4

[Stephan Leroux [:sleroux]]

So I think this is possible. Here's what we would need to do:

1. Build some native widget with a button that says "Open in iBooks" whenever the WKWebView is displaying a .PDF file. Currently Safari shows this as a toolbar that gets displayed at the top of a page showing a .PDF when the user taps on the screen.
2. When the user taps that button, we save a local copy of the PDF in our cache
3. Using the local file copy, launch iBooks using the itms-books:// url protocol

Some details here: http://stackoverflow.com/questions/26343420/open-local-pdf-file-in-ibooks

Not sure if this is v1.0 scope though

Comment 5

[Richard Newman [:rnewman]]

What other opening choices do we/should we have?

Comment 6

[Stephan Leroux [:sleroux]]

iOS provides a way for applications to register as a document handler by adding applications that can open files as part of the Open in context menu (https://developer.apple.com/library/ios/qa/qa1587/_index.html). I think if we support open in iBooks natively and then use the open in context menu for other applications we don't need to bundle in which applications can open what.

Comment 7

[Emily Toop (:fluffyemily)]

So, the Save PDF in iBooks option comes up automatically when I select the share extensions from FxiOS on my iPhone, but the resulting PDF has only the URL and no content. Looks like we may have to save the pdf locally first to ensure we have the content before sharing...

Comment 8

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Needs some design love. Made something up as I went along just to get it working

Comment 9

[Robin Andersen [:tecgirl]]

Comment on attachment 8663624 [details] [review]
Pull request

So far I can see the "Open in…" but nothing happens when I tap it.
http://c.tecgirl.com/dJel

Basic styling. http://c.tecgirl.com/dJ1R

Comment 10

[Emily Toop (:fluffyemily)]

:tecgirl - What device are you on, running which version of iOS?

Comment 11

[Robin Andersen [:tecgirl]]

(In reply to Emily Toop (:fluffyemily) from comment #10)
> :tecgirl - What device are you on, running which version of iOS?

6, 9.1

Comment 12

[Brian Nicholson (:bnicholson)]

Comment on attachment 8663624 [details] [review]
Pull request

Looks pretty good overall -- just lots of cleanup comments (many of which you ended up fixing in following commits). Since the follow-up commits are mostly incremental/fixup commits that that revert things in previous commits, I suggest folding them all together to make this easier to review/blame.

Comment 13

[Robin Andersen [:tecgirl]]

Comment on attachment 8663624 [details] [review]
Pull request

Emily, I took another look at this today, same device (6, 9.1) — but this time hosted the .pdf myself rather than trying to view it on dropbox or cl.ly.

The error I received when trying from dropbox or cl.ly: 
> view doesn't have a superview so can't open anything

But the "Open in…" button still shows.

If I open it from my server, I am able to access the "Copy to" share widget. I am able to "Copy to iBooks" successfully. Yay!

I'll + this and open a new bug to cover those instances where the .pdf is embedded, rendering the button useless.

Comment 14

[Brian Nicholson (:bnicholson)]

Comment on attachment 8663624 [details] [review]
Pull request

Nice, looks good! While testing this, I found some nasty rendering bugs when switching between multiple tabs with PDFs open, but looks like that's a WKWebView bug since it's reproducible in Safari.

Comment 15

[Richard Newman [:rnewman]]

Came across this:

https://davidgelphman.wordpress.com/2015/10/19/adding-save-pdf-to-ibooks-support-to-your-application/