Closed Bug 1183215 Opened 6 years ago Closed 6 years ago

Empty panel, History

Categories

(Firefox for iOS :: Home screen, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: tecgirl, Assigned: bmunar)

References

Details

Attachments

(4 files)

Currently nothing displays on the History panel if a user is not signed in to FxA or has engaged with at least one webview. Let's implement the same template with the string we use on Android: "Websites you visited most recently show up here." A new History icon asset will be added above the copy.
Blocks: 1183213
Depends on: 1168693
Assignee: nobody → bmunar
tracking-fxios: --- → ?
tracking-fxios: ? → ---
Attached file historyEmptyPanel.zip
Attached file PR
waiting for UI to give me the padding specifics for the text
Attachment #8638638 - Flags: ui-review?(randersen)
Attachment #8638638 - Flags: review?(bnicholson)
Comment on attachment 8638638 [details] [review]
PR

Looks good, but have some questions in the PR.
Attachment #8638638 - Flags: review?(bnicholson) → feedback+
Comment on attachment 8638638 [details] [review]
PR

smelly caaat smelly cat. what. r. they feeding u
Attachment #8638638 - Flags: feedback+ → feedback?(bnicholson)
Attachment #8638638 - Flags: feedback?(bnicholson) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8638638 [details] [review]
PR

Looks good.
Attachment #8638638 - Flags: ui-review?(randersen) → ui-review+
Depends on: 1188366
Attached file mock up
iPad layout?
That is a UX question ^^^
Flags: needinfo?(randersen)
(In reply to Aaron Train [:aaronmt] from comment #9)
> iPad layout?

Given its simplicity, no iPad-specific variation at this time.
Flags: needinfo?(randersen)
You need to log in before you can comment on or make changes to this bug.