1183367 - We should use eslint to validate frontend js in travis

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[William Lachance (:wlach)]

eslint (http://eslint.org/) provides a way to automatically validate that javascript follows certain best practices in terms of functionality and coding style. It's very similar in spirit to pyflakes.

To save some time reviewing frontend patches for various nits, I think we should run eslint in travis. This should hopefully simplify the review process somewhat (i.e.: we can ask people to make sure it passes the eslint tests before even starting review) -- :emorley already did this with pyflakes and it seems to have worked great.

It turns out that (unsurprisingly) our front end code currently violates the most basic rules (i.e. "no trailing whitespace", "camel case", "missing semicolon"). However, I think we can fix that incrementally and make our lives easier in the future. :)

Let's start with a patch that verifies a trivial rule ("no trailing whitespace"), then we can file followups to improve things from there.

Comment 1

[William Lachance (:wlach)]

Attachment: PR

This is a very basic test for trailing whitespace. Note that we currently fail it -- I'll file another bug to address that problem.

https://travis-ci.org/mozilla/treeherder/builds/70820499

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8633151 [details] [review]
PR

r=me with path addition

Thank you for doing this :-)

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/658927bdf7dce14f4a1e03580193f1aabbfe8c4a
Bug 1183367 - Add a grunt target to run eslint on JS frontend

Comment 4

[William Lachance (:wlach)]

Ok this is landed.