1183443 - Create shell scripts on the admin nodes for setting stage vs prod environment variables

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect, P2)

Description

[Ed Morley [:emorley]]

In bug 1160561 and friends we're moving towards using environment variables more, and local.py less. On the {stage,prod}-specific nodes we have /etc/profile.d/treeherder.sh for setting environment variables, however on the admin node we need a way to set environment variables when running commands as part of deploy.

I was thinking one way to do this would be to get the same content that's in /etc/profile.d/treeherder.sh on the non-admin nodes, be saved into `treeherder-env.sh` or similar in each of these locations:
/data/treeherder-stage/src/treeherder.allizom.org/treeherder-service/treeherder-env.sh
/data/treeherder/src/treeherder.mozilla.org/treeherder-service/treeherder-env.sh

I can then call these in update.py prior to commands that need them.

As an added bonus, if I ever needed to make changes, I could just create a new file alongside treeherder-env.sh and ask you to update the content in puppet to match.

fubar, does that sound like a reasonable approach? :-)

Comment 1

[Ed Morley [:emorley]]

Sorry, corrected path:

/data/treeherder-stage/src/treeherder.allizom.org/treeherder-env.sh
/data/treeherder/src/treeherder.mozilla.org/treeherder-env.sh

Comment 2

[Kendall Libby [:fubar] (he/him)]

Sounds good. Added to puppet and they're on the admin node now.

Comment 3

[Ed Morley [:emorley]]

That's great - thank you :-)