1183486 - Repeated crash when tapping URL bar immediately after opening app (build 24)

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Richard Newman [:rnewman]]

One tab was restoring. Tap bar, crash. App relaunches. Did this multiple times.

Crash log:

https://gist.github.com/rnewman/2e791147f523172a85b4

I don't have the dSYM to symbolicate this. St3fan?

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Archive for Firefox 1.0 (24):

https://www.dropbox.com/s/k9gt7xfll13rvhn/Firefox%202015-07-10%2C%203.55%20PM.xcarchive.zip?dl=0

I don't know how to manually symbolicate. You may be able to simply import this xcarchive in the navigator and then drop the crash report in there too. Not entirely sure.

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: URLBarCrash.crash

Added symbolicated crash

Comment 3

[Stephan Leroux [:sleroux]]

I'm having a hard time reproducing this on latest master and build 24 from builds/AuroraV24 branch. The symbolicated crash is pointing me to L135 in HomePanelViewController where we are removing the current panel's view from the superview. I have a hard time seeing why this would crash. The only thing I can think of is that view is not allocated yet and is actually nil which is causing an explict unwrap crash. A safe fix would be to just check to see if the current panel's view even has a super view and only remove it if it's actually being shown.

Was there any other tips to reproduce this so I can reliably put the fix in?

Comment 4

[Aaron Train [:aaronmt]]

Another report on ios-feedback https://groups.google.com/a/mozilla.com/d/msgid/ios-feedback/1437489422.150402313%40f16.my.com?utm_medium=email&utm_source=footer

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/778

Comment 6

[Richard Newman [:rnewman]]

(In reply to Stephan Leroux [:sleroux] from comment #3)
 
> Was there any other tips to reproduce this so I can reliably put the fix in?

Just hurrying, really. Timing-related bugs are a bear.

Comment 7

[Brian Nicholson (:bnicholson)]

Comment on attachment 8636675 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/778

Hm, we probably do this incorrectly in all of the other places we add/remove controllers. Think those are worth fixing too?

Comment 8

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/778

I did a search for where we addChildViewController/removeFromParentViewController and updated those parts as well.

Comment 9

[Brian Nicholson (:bnicholson)]

Comment on attachment 8638017 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/778

Nice, hopefully this fixes the crashes!

Comment 10

[Stephan Leroux [:sleroux]]

Merged