Repeated crash when tapping URL bar immediately after opening app (build 24)

RESOLVED FIXED

Status

()

--
critical
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: rnewman, Assigned: sleroux)

Tracking

({crash})

unspecified
ARM
iOS
crash

Firefox Tracking Flags

(fxios+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
One tab was restoring. Tap bar, crash. App relaunches. Did this multiple times.

Crash log:

https://gist.github.com/rnewman/2e791147f523172a85b4

I don't have the dSYM to symbolicate this. St3fan?
Flags: needinfo?(sarentz)
Archive for Firefox 1.0 (24):

https://www.dropbox.com/s/k9gt7xfll13rvhn/Firefox%202015-07-10%2C%203.55%20PM.xcarchive.zip?dl=0

I don't know how to manually symbolicate. You may be able to simply import this xcarchive in the navigator and then drop the crash report in there too. Not entirely sure.
Flags: needinfo?(sarentz)
(Reporter)

Updated

4 years ago
tracking-fxios: ? → +
(Assignee)

Comment 2

3 years ago
Created attachment 8636140 [details]
URLBarCrash.crash

Added symbolicated crash
(Assignee)

Updated

3 years ago
Assignee: nobody → sleroux
(Assignee)

Comment 3

3 years ago
I'm having a hard time reproducing this on latest master and build 24 from builds/AuroraV24 branch. The symbolicated crash is pointing me to L135 in HomePanelViewController where we are removing the current panel's view from the superview. I have a hard time seeing why this would crash. The only thing I can think of is that view is not allocated yet and is actually nil which is causing an explict unwrap crash. A safe fix would be to just check to see if the current panel's view even has a super view and only remove it if it's actually being shown.

Was there any other tips to reproduce this so I can reliably put the fix in?
(Assignee)

Updated

3 years ago
Flags: needinfo?(rnewman)
Severity: normal → critical
(Reporter)

Comment 6

3 years ago
(In reply to Stephan Leroux [:sleroux] from comment #3)
 
> Was there any other tips to reproduce this so I can reliably put the fix in?

Just hurrying, really. Timing-related bugs are a bear.
Flags: needinfo?(rnewman)
(Reporter)

Updated

3 years ago
Status: NEW → ASSIGNED
Comment on attachment 8636675 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/778

Hm, we probably do this incorrectly in all of the other places we add/remove controllers. Think those are worth fixing too?
Attachment #8636675 - Flags: review?(bnicholson) → review+
(Assignee)

Updated

3 years ago
Attachment #8636675 - Attachment is obsolete: true
(Assignee)

Comment 8

3 years ago
Created attachment 8638017 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/778

I did a search for where we addChildViewController/removeFromParentViewController and updated those parts as well.
Attachment #8638017 - Flags: review?(bnicholson)
Comment on attachment 8638017 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/778

Nice, hopefully this fixes the crashes!
Attachment #8638017 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 10

3 years ago
Merged
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.