1183522 - SIMD: make toSource use the new capitalization

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:ProgramFOX]

Attachment: SIMD: make toSource use the new capitalization

The SIMD objects now start with a capital letter, but this was not yet changed for toSource.

Comment 1

[Benjamin Bouvier [:bbouvier]]

Comment on attachment 8633341 [details] [diff] [review]
SIMD: make toSource use the new capitalization

Review of attachment 8633341 [details] [diff] [review]:
-----------------------------------------------------------------

Indeed (this changed in the spec after I made my patch!). However, you also need to prefix the Type name by SIMD, so that the code is homoiconic: https://github.com/tc39/ecmascript_simd/commit/1d9079b31b2a02206ce8bc6a13dc1e7127bc9b89

Comment 2

[Benjamin Bouvier [:bbouvier]]

(And thank you for the patch, btw)

Comment 3

[:ProgramFOX]

Attachment: SIMD: make toSource use the new capitalization and give it the SIMD prefix

Updated patch, with the SIMD prefix added.

Comment 4

[Benjamin Bouvier [:bbouvier]]

Comment on attachment 8634606 [details] [diff] [review]
SIMD: make toSource use the new capitalization and give it the SIMD prefix

Review of attachment 8634606 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you! Can you also move the ToSource test to tests/ecma_7/SIMD, please?

Comment 5

[:ProgramFOX]

Attachment: SIMD: made toSource use the new capitalization and give it the SIMD prefix

Comment 6

[:ProgramFOX]

Comment on attachment 8635221 [details] [diff] [review]
SIMD: made toSource use the new capitalization and give it the SIMD prefix

Updated patch, with the test file moved.

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b978be405b4

Comment 7

[:ProgramFOX]

Try push returned green after having to retrigger some jobs; adding checkin-needed.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/acc29d2bc390

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/acc29d2bc390

Comment 10

[Florian Scholz (Open Web Docs)]

Added to the list here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/toSource#Built-in_toSource()_methods

Added a new page https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SIMD/toSource

Marked as non-standard.