Closed
Bug 1183522
Opened 9 years ago
Closed 9 years ago
SIMD: make toSource use the new capitalization
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: ProgramFOX, Assigned: ProgramFOX)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 2 obsolete files)
|
5.43 KB,
patch
|
ProgramFOX
:
review+
|
Details | Diff | Splinter Review |
The SIMD objects now start with a capital letter, but this was not yet changed for toSource.
Attachment #8633341 -
Flags: review?(benj)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8633341 [details] [diff] [review] SIMD: make toSource use the new capitalization Review of attachment 8633341 [details] [diff] [review]: ----------------------------------------------------------------- Indeed (this changed in the spec after I made my patch!). However, you also need to prefix the Type name by SIMD, so that the code is homoiconic: https://github.com/tc39/ecmascript_simd/commit/1d9079b31b2a02206ce8bc6a13dc1e7127bc9b89
Attachment #8633341 -
Flags: review?(benj)
|
|
||
Comment 2•9 years ago
|
||
(And thank you for the patch, btw)
|
Assignee | |
Comment 3•9 years ago
|
||
Updated patch, with the SIMD prefix added.
Attachment #8633341 -
Attachment is obsolete: true
Attachment #8634606 -
Flags: review?(benj)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8634606 [details] [diff] [review] SIMD: make toSource use the new capitalization and give it the SIMD prefix Review of attachment 8634606 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thank you! Can you also move the ToSource test to tests/ecma_7/SIMD, please?
Attachment #8634606 -
Flags: review?(benj) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8635221 [details] [diff] [review] SIMD: made toSource use the new capitalization and give it the SIMD prefix Updated patch, with the test file moved. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b978be405b4
Attachment #8635221 -
Attachment description: tosource-capitalization3.diff → SIMD: made toSource use the new capitalization and give it the SIMD prefix
Attachment #8635221 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8634606 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → programfox
|
|
Assignee | |
Comment 7•9 years ago
|
||
Try push returned green after having to retrigger some jobs; adding checkin-needed.
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: dev-doc-needed
|
||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/acc29d2bc390
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
||
Comment 10•9 years ago
|
||
Added to the list here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/toSource#Built-in_toSource()_methods Added a new page https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SIMD/toSource Marked as non-standard.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•