Closed Bug 1183578 Opened 5 years ago Closed 5 years ago

[RIL] Gecko gets no response from rild for pin2 and puk2 operation

Categories

(Firefox OS Graveyard :: Emulator, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

When rewriting a test case regarding to pin2 and puk2 for bug 1159591, I found an issue that the gecko gets no response from rild for pin2 and puk2 operation.
After doing some debug, I found this issue is a regression of bug 1083650 [1].

If we intent to reply "Request Not Supported" error for pin2 and puk2 operation, we should remove PIN2 and PUK2 from the switch-case, instead of break directly.

[1] https://github.com/mozilla-b2g/platform_hardware_ril/commit/15dea046f29fce12c0b2775cba35158eea55dd25
Comment on attachment 8633867 [details] [review]
[platform_hardware_ril:b2g-ril_v7] PR #64

Hi aknow, could you help to review this? Please see comment #0 for the details. Thank you.
Attachment #8633867 - Flags: review?(szchen)
Comment on attachment 8633867 [details] [review]
[platform_hardware_ril:b2g-ril_v7] PR #64

I've left my comment on github. It's just my idea and it's up to you to decide whether or not to adopt it.
Attachment #8633867 - Flags: review?(szchen) → review+
Thank you, aknow.

https://github.com/mozilla-b2g/platform_hardware_ril/commit/8bc59310552179f9a8bc6cdd0188e2475df52fb7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.