1183578 - [RIL] Gecko gets no response from rild for pin2 and puk2 operation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Edgar Chen [:edgar]]

When rewriting a test case regarding to pin2 and puk2 for bug 1159591, I found an issue that the gecko gets no response from rild for pin2 and puk2 operation.
After doing some debug, I found this issue is a regression of bug 1083650 [1].

If we intent to reply "Request Not Supported" error for pin2 and puk2 operation, we should remove PIN2 and PUK2 from the switch-case, instead of break directly.

[1] https://github.com/mozilla-b2g/platform_hardware_ril/commit/15dea046f29fce12c0b2775cba35158eea55dd25

Comment 1

[Edgar Chen [:edgar]]

Attachment: [platform_hardware_ril:b2g-ril_v7] PR #64

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8633867 [details] [review]
[platform_hardware_ril:b2g-ril_v7] PR #64

Hi aknow, could you help to review this? Please see comment #0 for the details. Thank you.

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8633867 [details] [review]
[platform_hardware_ril:b2g-ril_v7] PR #64

I've left my comment on github. It's just my idea and it's up to you to decide whether or not to adopt it.

Comment 4

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&exclusion_profile=false

Comment 5

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #4)
> Try result:
> https://treeherder.mozilla.org/#/jobs?repo=try&author=echen@mozilla.
> com&exclusion_profile=false

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8ddbdaa16bf&exclusion_profile=false

Comment 6

[Edgar Chen [:edgar]]

Thank you, aknow.

https://github.com/mozilla-b2g/platform_hardware_ril/commit/8bc59310552179f9a8bc6cdd0188e2475df52fb7

Comment 7

[Edgar Chen [:edgar]]

b2g-kitkat:
https://github.com/mozilla-b2g/platform_hardware_ril/commit/3bd3e49411b3b6c67a3ea1cc5a11f083953725bc