1183581 - browser_storage_dynamic_windows.js IsSafeToRunScript errors when testing reload in E10S mode

Status: RESOLVED WONTFIX

(DevTools :: Storage Inspector, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This test has a testReload() method that fails on E10S builds.

Search for this bug number inside browser_storage_dynamic_windows.js to re-enable this section of the test and investigate.

I suspect that we are best to move the scripts from storage-dynamic-windows.html to fix this.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This has been quite a pain as fixing it with the way it currently runs results in intermittent oranges. The current test is very hard to follow and badly needs a rewrite... there is no need for it to be as complex as it currently is.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: [WIP] 1183581-browser-storage-dynamic-windows-js-fix.diff

It turns out that the test is complicated for a reason. When the storage actor has changes they are passed as batched of added and deleted items. Because we use batches we need to catch all changes and build a picture of what the current state actually looks like.

The simple fact is that it is much simpler to test reloads in the client as the tablewidget takes care of this side so the tests are much simpler.

I will check if we test reloads in the frontend.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

No, we don't test for reloads on the frontend either.

I am dropping this as other tasks have a higher priority.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

When we reload the storage inspector is completely reinitialized so there is no need for this test. We could create a complex test specifically to test reloads but we can make much better use of man hours than that.