Closed Bug 1183633 Opened 9 years ago Closed 9 years ago

Use PingFang SC/TC as default Chinese fallback in OS X 10.11

Categories

(Core :: Graphics: Text, defect)

Product:
Core
Component:
Graphics: Text
Version:
39 Branch
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: mwei, Assigned: mwei)

Details

(Keywords: fonts)

Attachments

(2 files, 1 obsolete file)

Patch for checking in to the repo.
2.42 KB, patch
jtd
: review+
Details | Diff | Splinter Review
DefaultFontFallback.plist
7.84 KB, application/xml
Details 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150630154324

Steps to reproduce:

Use Firefox in OS X 10.11.


Actual results:

Found Heiti TC Chinese glyph is shown.


Expected results:

PingFang TC/SC Chinese glyphs should be shown.
Keywords: fonts
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86_64
Attached patch Patch (obsolete) — — Splinter Review 

    
  
Component: Untriaged → Graphics: Text
Product: Firefox → Core

    
  

        Attachment #8633470 -
        Flags: review?(jdaggett)

    
    

    
  
Comment on attachment 8633470 [details] [diff] [review]
Patch

Review of attachment 8633470 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine, assuming the family names are listed here correctly. Yao, did you verify that all three fonts get picked up?

        Attachment #8633470 -
        Flags: review?(jdaggett) → review+

    
  
Assignee: nobody → mwei

    
  
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
  
Keywords: checkin-needed

    
    

    
  
By modifying about:config and confirmed that the fonts (PingFang TC, PingFang SC) are picked up.  It is the new system default font in Traditional Chinese and Simplified Chinese in OS X 10.11.

    
    

    
  


  

        Attachment #8633470 -
        Attachment is obsolete: true

    
  

        Attachment #8634588 -
        Flags: review+

    
    

    
  
:liuxing, this patch will also affect zh-CN default fallback.

    
    

    
  
Yao, could I ask you a favor? Could you run the command below under 10.11 and attach the output?

$ plutil -convert xml1 -o - /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreText.framework/Resources/DefaultFontFallbacks.plist

Thanks!
Flags: needinfo?(mwei)

    
    

    
  


  
Flags: needinfo?(mwei)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/30cdd1b7fe4e
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox42:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

          You need to log in
          before you can comment on or make changes to this bug.