Use PingFang SC/TC as default Chinese fallback in OS X 10.11

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mwei, Assigned: mwei)

Tracking

({fonts})

39 Branch
mozilla42
x86_64
Mac OS X
fonts
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150630154324

Steps to reproduce:

Use Firefox in OS X 10.11.


Actual results:

Found Heiti TC Chinese glyph is shown.


Expected results:

PingFang TC/SC Chinese glyphs should be shown.
(Assignee)

Updated

3 years ago
Keywords: fonts
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86_64
(Assignee)

Comment 1

3 years ago
Created attachment 8633470 [details] [diff] [review]
Patch

Updated

3 years ago
Component: Untriaged → Graphics: Text
Product: Firefox → Core

Updated

3 years ago
Attachment #8633470 - Flags: review?(jdaggett)

Comment 2

3 years ago
Comment on attachment 8633470 [details] [diff] [review]
Patch

Review of attachment 8633470 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine, assuming the family names are listed here correctly. Yao, did you verify that all three fonts get picked up?
Attachment #8633470 - Flags: review?(jdaggett) → review+

Updated

3 years ago
Assignee: nobody → mwei

Updated

3 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

3 years ago
By modifying about:config and confirmed that the fonts (PingFang TC, PingFang SC) are picked up.  It is the new system default font in Traditional Chinese and Simplified Chinese in OS X 10.11.
(Assignee)

Comment 4

3 years ago
Created attachment 8634588 [details] [diff] [review]
Patch for checking in to the repo.
Attachment #8633470 - Attachment is obsolete: true

Updated

3 years ago
Attachment #8634588 - Flags: review+

Comment 5

3 years ago
:liuxing, this patch will also affect zh-CN default fallback.

Comment 6

3 years ago
Yao, could I ask you a favor? Could you run the command below under 10.11 and attach the output?

$ plutil -convert xml1 -o - /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreText.framework/Resources/DefaultFontFallbacks.plist

Thanks!
Flags: needinfo?(mwei)
(Assignee)

Comment 7

3 years ago
Created attachment 8634603 [details]
DefaultFontFallback.plist
Flags: needinfo?(mwei)
https://hg.mozilla.org/mozilla-central/rev/30cdd1b7fe4e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.