1183633 - Use PingFang SC/TC as default Chinese fallback in OS X 10.11

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Yao Wei]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150630154324

Steps to reproduce:

Use Firefox in OS X 10.11.


Actual results:

Found Heiti TC Chinese glyph is shown.


Expected results:

PingFang TC/SC Chinese glyphs should be shown.

Comment 1

[Yao Wei]

Attachment: Patch

Comment 2

[John Daggett (:jtd)]

Comment on attachment 8633470 [details] [diff] [review]
Patch

Review of attachment 8633470 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine, assuming the family names are listed here correctly. Yao, did you verify that all three fonts get picked up?

Comment 3

[Yao Wei]

By modifying about:config and confirmed that the fonts (PingFang TC, PingFang SC) are picked up.  It is the new system default font in Traditional Chinese and Simplified Chinese in OS X 10.11.

Comment 4

[Yao Wei]

Attachment: Patch for checking in to the repo.

Comment 5

[Irvin (MozTW)]

:liuxing, this patch will also affect zh-CN default fallback.

Comment 6

[John Daggett (:jtd)]

Yao, could I ask you a favor? Could you run the command below under 10.11 and attach the output?

$ plutil -convert xml1 -o - /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreText.framework/Resources/DefaultFontFallbacks.plist

Thanks!

Comment 7

[Yao Wei]

Attachment: DefaultFontFallback.plist

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30cdd1b7fe4e

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/30cdd1b7fe4e