1183824 - 3,300 instances of "NS_ENSURE_TRUE(mCallback) failed" emitted from dom/base/nsFrameMessageManager.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Eric Rahm [:erahm]]

> 3337 [NNNNN] WARNING: NS_ENSURE_TRUE(mCallback) failed: file dom/base/nsFrameMessageManager.cpp, line 803

This warning [1] was introduced in bug 776832, shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:1024
> mozilla-central_ubuntu64_vm-debug_test-mochitest-3-bm115-tests1-linux64-build21.txt:663
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:374
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:285
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm122-tests1-linux64-build19.txt:203
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm122-tests1-linux64-build17.txt:192
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm53-tests1-linux64-build0.txt:170
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:143
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:137
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm121-tests1-linux64-build0.txt:59
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:20
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm51-tests1-linux64-build0.txt:14
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:12
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-3-bm115-tests1-linux64-build9.txt:9
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm52-tests1-linux64-build11.txt:9
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:5
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-4-bm51-tests1-linux64-build3.txt:5
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-2-bm120-tests1-linux64-build0.txt:5
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm123-tests1-linux64-build2.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:1

It shows up in 533 tests. A few of the most prevalent:

> 630 - dom/tests/mochitest/bugs/test_bug260264.html
> 148 - browser/components/search/test/browser_healthreport.js
> 110 - browser/base/content/test/general/browser_remoteTroubleshoot.js
> 88 - browser/base/content/test/general/browser_relatedTabs.js
> 66 - dom/devicestorage/test/test_fs_app_permissions.html
> 58 - browser/base/content/test/general/browser_bug590206.js
> 48 - dom/devicestorage/test/test_app_permissions.html
> 44 - browser/components/search/test/browser_hiddenOneOffs_cleanup.js
> 44 - browser/base/content/test/general/browser_selectpopup.js
> 39 - browser/components/sessionstore/test/browser_formdata_cc.js

[1] https://hg.mozilla.org/mozilla-central/annotate/e786406bc683/dom/base/nsFrameMessageManager.cpp#l803

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I think it is fine to silence this one.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Remove NS_ENSURE_TRUE(mCallback, NS_ERROR_NOT_INITIALIZED) warning from nsFrameMessageManager::DispatchAsyncMessageInternal

Comment 3

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2236eaa85b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc2236eaa85b