Closed
Bug 1183883
Opened 9 years ago
Closed 9 years ago
2,200 instances of "Graph thread slowdown?: 'std::abs(framePosition - CurrentDriver()->StateComputedTime()) < MillisecondsToMediaTime(5)'" emitted from dom/media/MediaStreamGraph.cpp during linux64 debug testing
Categories
(Core :: WebRTC: Audio/Video, defect)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
1.90 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
1.91 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #848954 +++ > 2206 [NNNNN] WARNING: Graph thread slowdown?: 'std::abs(framePosition - CurrentDriver()->StateComputedTime()) < MillisecondsToMediaTime(5)', file dom/media/MediaStreamGraph.cpp, line 1194 Considering this is output only during debug builds it might not be worth emitting. Alternatively it could be converted to a STREAM_LOG message or something similar. This warning [1] shows up in the following test suites: > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:1281 > mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:925 It shows up in 51 tests. A few of the most prevalent: > 544 - dom/media/tests/mochitest/test_peerConnection_twoAudioVideoStreamsCombined.html > 488 - dom/media/tests/mochitest/test_peerConnection_twoAudioVideoStreams.html > 348 - dom/media/tests/mochitest/test_peerConnection_twoAudioVideoStreamsCombined.html > 240 - dom/media/tests/mochitest/test_peerConnection_twoAudioVideoStreams.html > 100 - dom/media/tests/mochitest/test_peerConnection_capturedVideo.html > 96 - dom/media/tests/mochitest/test_peerConnection_replaceTrack.html > 57 - dom/media/tests/mochitest/test_peerConnection_forwarding_basicAudioVideoCombined.html > 40 - dom/media/tests/mochitest/test_peerConnection_basicAudioVideoNoBundle.html > 40 - dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html > 40 - dom/media/tests/mochitest/test_dataChannel_basicAudioVideoNoBundle.html [1] https://hg.mozilla.org/mozilla-central/annotate/e786406bc683/dom/media/MediaStreamGraph.cpp#l1194
Assignee | ||
Comment 1•9 years ago
|
||
The graph thread slowdown warning is switched over to a STREAM_LOG message in an #ifdef DEBUG block to preserve the debug only semantics of NS_WARN_IF_FALSE. The message will still be emitted if the STREAM_LOG is enabled.
Attachment #8633807 -
Flags: review?(roc)
Attachment #8633807 -
Flags: feedback?(padenot)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8633807 [details] [diff] [review] Switch graph thread slowdown warning to log message Review of attachment 8633807 [details] [diff] [review]: ----------------------------------------------------------------- That's fine, yes.
Attachment #8633807 -
Flags: review?(roc)
Attachment #8633807 -
Flags: review+
Attachment #8633807 -
Flags: feedback?(padenot)
Assignee | ||
Comment 3•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/e15709852fab130dc0dcbdfbd3c3070f0616124e changeset: e15709852fab130dc0dcbdfbd3c3070f0616124e user: Eric Rahm <erahm@mozilla.com> date: Thu Jul 16 09:17:31 2015 -0700 description: Bug 1183883 - Switch graph thread slowdown warning to log message. r=padenot The graph thread slowdown warning is switched over to a STREAM_LOG message in an #ifdef DEBUG block to preserve the debug only semantics of NS_WARN_IF_FALSE. The message will still be emitted if the STREAM_LOG is enabled.
Assignee | ||
Comment 4•9 years ago
|
||
The graph thread slowdown warning is switched over to a STREAM_LOG message in an #ifdef DEBUG block to preserve the debug only semantics of NS_WARN_IF_FALSE. The message will still be emitted if the STREAM_LOG is enabled.
Attachment #8635061 -
Flags: review?(roc)
Attachment #8635061 -
Flags: feedback?(padenot)
Attachment #8635061 -
Flags: review?(roc) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(sorry ran bzexport again by mistake, same patch padenot alread r+'d)
Assignee | ||
Updated•9 years ago
|
Attachment #8635061 -
Flags: feedback?(padenot)
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e15709852fab
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•