Closed
Bug 1183888
Opened 6 years ago
Closed 6 years ago
3,100 instances of "NS_ENSURE_TRUE(HaveStartTime()) failed" emitted from dom/media/ during linux64 debug testing
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: erahm, Assigned: jya)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.44 KB,
patch
|
jya
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1179110 +++ > 2083 [NNNNN] WARNING: NS_ENSURE_TRUE(HaveStartTime()) failed: file dom/media/ogg/OggReader.cpp, line 1843 This warning [1], introduced in bug 1179110 patch 1 shows up in the following test suites: > mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:1235 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:1189 > mozilla-central_ubuntu64_vm-debug_test-reftest-3-bm52-tests1-linux64-build0.txt:310 > mozilla-central_ubuntu64_vm-debug_test-crashtest-bm53-tests1-linux64-build28.txt:215 > mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:41 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:22 > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:13 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:9 > mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:7 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:7 > mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:7 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm121-tests1-linux64-build0.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-3-bm115-tests1-linux64-build21.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm122-tests1-linux64-build19.txt:3 > mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:1 > mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm53-tests1-linux64-build27.txt:1 It shows up in 356 tests. A few of the most prevalent: > 200 - file:///builds/slave/test/build/tests/reftest/tests/dom/media/test/crashtests/691096-1.html > 108 - dom/media/test/test_playback.html > 104 - dom/media/test/test_playback.html > 81 - dom/media/test/test_closing_connections.html > 76 - dom/media/test/test_media_selection.html > 71 - dom/media/test/test_media_selection.html > 71 - dom/media/test/test_closing_connections.html > 50 - dom/media/test/test_load.html > 50 - dom/media/test/test_load.html > 48 - dom/media/test/test_played.html [1] https://hg.mozilla.org/mozilla-central/annotate/e786406bc683/dom/media/ogg/OggReader.cpp#l1843
Reporter | ||
Updated•6 years ago
|
OS: Windows 7 → Unspecified
Reporter | ||
Comment 1•6 years ago
|
||
Bobby, would you mind taking a look at this? It seems to have been introduced recently by bug 1179110.
Flags: needinfo?(bobbyholley)
Comment 2•6 years ago
|
||
(In reply to Eric Rahm [:erahm] from comment #1) > Bobby, would you mind taking a look at this? It seems to have been > introduced recently by bug 1179110. 302 jya. ;-)
Flags: needinfo?(bobbyholley) → needinfo?(jyavenard)
Reporter | ||
Comment 3•6 years ago
|
||
> 990 [NNNNN] WARNING: NS_ENSURE_TRUE(HaveStartTime()) failed: file dom/media/webm/WebMReader.cpp, line 781 This is more than just ogg, I see it in WebMReader as well. This warning [1] shows up in the following test suites: > mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:357 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:355 > mozilla-central_ubuntu64_vm-debug_test-reftest-3-bm52-tests1-linux64-build0.txt:272 > mozilla-central_ubuntu64_vm-debug_test-crashtest-bm53-tests1-linux64-build28.txt:3 > mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:1 > mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm53-tests1-linux64-build27.txt:1 > mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:1 It shows up in 116 tests. A few of the most prevalent: > 64 - dom/media/test/test_media_selection.html > 40 - dom/media/test/test_load.html > 32 - dom/media/test/test_reset_src.html > 24 - dom/media/test/test_played.html > 21 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-scale-down-webm-002.html > 21 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-scale-down-webm-001.html > 21 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-none-webm-002.html > 21 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-none-webm-001.html > 21 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-fill-webm-002.html > 21 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-fill-webm-001.html
Summary: 2,100 instances of "NS_ENSURE_TRUE(HaveStartTime()) failed" emitted from dom/media/ogg/OggReader.cpp during linux64 debug testing → 3,100 instances of "NS_ENSURE_TRUE(HaveStartTime()) failed" emitted from dom/media/ during linux64 debug testing
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jyavenard
Flags: needinfo?(jyavenard)
Assignee | ||
Comment 4•6 years ago
|
||
WebM will be automatically fixed once bug 1185792 goes in
Assignee | ||
Comment 5•6 years ago
|
||
Carrying r+ as per https://bugzilla.mozilla.org/show_bug.cgi?id=1179110#c25
Attachment #8637139 -
Flags: review+
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ca8c45b90a5
Assignee | ||
Comment 7•6 years ago
|
||
Duh... A bit silly try run that contains currently non-working patches I'm working on.
Assignee | ||
Comment 8•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a68543d5a7f3
https://hg.mozilla.org/mozilla-central/rev/fedceb06f2e2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•