1183902 - _shareStringWithDefault is unused

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

A definition and no uses:

https://mxr.mozilla.org/mozilla-central/search?string=_shareStringWithDefault&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Margaret, I'm not missing anything, right?

Comment 1

[:Margaret Leibovic]

Looking at blame, this was added in this changeset:
http://hg.mozilla.org/mozilla-central/rev/02b6677f5f8d

And then its consumers were removed here:
http://hg.mozilla.org/mozilla-central/rev/c437a98128f4

I guess that "showAsActions" property just takes care of this for us now.

So yeah, I think you can kill this.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 3

[Giovanny Gongora [:gioyik]]

Attachment: 1183902.patch

Comment 4

[Giovanny Gongora [:gioyik]]

Hi,

I submitted a patch for this bug. Let me know if is a good one or needs modifications.

Thanks

P.S Sorry for the double review with the same person.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=67157c1a858c

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8637647 [details] [diff] [review]
1183902.patch

Review of attachment 8637647 [details] [diff] [review]:
-----------------------------------------------------------------

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 7

[Giovanny Gongora [:gioyik]]

Michael,

Treeherder is showing 3 test as failed. Could you help me to understand how fix them?

Thanks

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Giovanny Gongora [:gioyik] from comment #7)
> Treeherder is showing 3 test as failed. Could you help me to understand how
> fix them?

Our test suites often get intermittent failures and this looks like one of them. To check, you can see if the suite has been re-run (i.e. there is another test suite with the same name on the same device) and if that was green. Additionally, if you click a failing test suite, you can look at the bar on the bottom of the screen and see if it matches any existing known intermittent failures, which are also listed on that bar.

So this looks good to me and is ready for check-in!

Comment 9

[Giovanny Gongora [:gioyik]]

That's good to know. Thank you for the feedback.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f846219745ee

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f846219745ee