Closed Bug 1183951 Opened 5 years ago Closed 4 years ago

Store the uid as the login manager "username" instead of the email address for Firefox 44

Categories

(Firefox :: Firefox Accounts, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: markh, Assigned: markh)

Details

(Whiteboard: [sync-quality])

Attachments

(1 file)

In bug 1157529 we landed support for the FxA code to handle the user's uid being used as the login manager "username" to better support changing email addresses for users. However, that bug did not actually write the uid, as that would cause breakage if those users used Nightly (and thus had the uid written) then used Release (which would not recognize the uid). So once that bug hits the release channel we should start writing the uid and rely on the fact that all current versions of Firefox will happily read the uid.

We expect bug 1157529 to hit release with Firefox 41, so we should land this patch while Firefox 44 is on nightly (meaning 41 will then be release)
Mark, is this some work we missed following up on?
Flags: needinfo?(markh)
Priority: P1 → P2
(In reply to Chris Karlof [:ckarlof] from comment #1)
> Mark, is this some work we missed following up on?

Yes! We should do this; It is a small patch and P2 sounds right.
Flags: needinfo?(markh)
Priority: P2 → P1
Whiteboard: [sync-quality]
Assignee: nobody → markh
Comment on attachment 8781324 [details]
Bug 1183951 - use the uid instead of the email address as the key into the login manager storage for FxA account information.

https://reviewboard.mozilla.org/r/71738/#review69284
Attachment #8781324 - Flags: review?(kcambridge) → review+
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/72696d61d5fc
use the uid instead of the email address as the key into the login manager storage for FxA account information. r=kitcambridge
https://hg.mozilla.org/mozilla-central/rev/72696d61d5fc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox
Target Milestone: mozilla51 → Firefox 51
You need to log in before you can comment on or make changes to this bug.