1183951 - Store the uid as the login manager "username" instead of the email address for Firefox 44

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

In bug 1157529 we landed support for the FxA code to handle the user's uid being used as the login manager "username" to better support changing email addresses for users. However, that bug did not actually write the uid, as that would cause breakage if those users used Nightly (and thus had the uid written) then used Release (which would not recognize the uid). So once that bug hits the release channel we should start writing the uid and rely on the fact that all current versions of Firefox will happily read the uid.

We expect bug 1157529 to hit release with Firefox 41, so we should land this patch while Firefox 44 is on nightly (meaning 41 will then be release)

Comment 1

[Chris Karlof [:ckarlof]]

Mark, is this some work we missed following up on?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

(In reply to Chris Karlof [:ckarlof] from comment #1)
> Mark, is this some work we missed following up on?

Yes! We should do this; It is a small patch and P2 sounds right.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1183951 - use the uid instead of the email address as the key into the login manager storage for FxA account information.

Review commit: https://reviewboard.mozilla.org/r/71738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71738/

Comment 4

[Lina Butler (ex-Mozilla)]

Comment on attachment 8781324 [details]
Bug 1183951 - use the uid instead of the email address as the key into the login manager storage for FxA account information.

https://reviewboard.mozilla.org/r/71738/#review69284

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72696d61d5fc
use the uid instead of the email address as the key into the login manager storage for FxA account information. r=kitcambridge

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/72696d61d5fc