Closed Bug 1183957 Opened 7 years ago Closed 7 years ago

Crash: assertionFailure in Storage.Login.formSubmitURL.setter during password sync

Categories

(Firefox for iOS :: Sync, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: rnewman, Assigned: rnewman)

Details

(Keywords: crash)

Attachments

(1 file)

47 bytes, text/x-github-pull-request
wesj
: review+
fluffyemily
: review+
Details | Review
if url1?.host != url2?.host {
                assertionFailure("Form submit URL domain doesn't match login's domain.")
                self._formSubmitURL = nil
                return
            }
Wes, I'm pretty sure you wanted to remove this, right?
Yes.
This call stack is while constructing a record from Sync server data. That means we definitely have password records in the wild for which formSubmitURL doesn't match the record's hostname.
Attached file Pull req.
Attachment #8634131 - Flags: review?(wjohnston)
Attachment #8634131 - Flags: review?(etoop)
Attachment #8634131 - Flags: review?(wjohnston) → review+
Attachment #8634131 - Flags: review?(etoop) → review+
https://github.com/mozilla/firefox-ios/commit/0c14a49a0ab1761365fe6d39b5f33150765efb7e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.