1183957 - Crash: assertionFailure in Storage.Login.formSubmitURL.setter during password sync

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

if url1?.host != url2?.host {
                assertionFailure("Form submit URL domain doesn't match login's domain.")
                self._formSubmitURL = nil
                return
            }

Comment 1

[Richard Newman [:rnewman]]

Wes, I'm pretty sure you wanted to remove this, right?

Comment 2

[Wesley Johnston (:wesj)]

Yes.

Comment 3

[Richard Newman [:rnewman]]

This call stack is while constructing a record from Sync server data. That means we definitely have password records in the wild for which formSubmitURL doesn't match the record's hostname.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Pull req.

Comment 5

[Richard Newman [:rnewman]]

https://github.com/mozilla/firefox-ios/commit/0c14a49a0ab1761365fe6d39b5f33150765efb7e