Closed Bug 1184170 Opened 10 years ago Closed 10 years ago

In the Sync Preferences, return the Terms of Service and Privacy Notice to different lines with added margin

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: rfeeley, Assigned: eoger)

References

(
URL
)

Details

Attachments

(1 file)

bug-1184170.patch
1.52 KB, patch
markh
: review+
Details | Diff | Splinter Review
Hi Edouard, sorry about this. Bryan is right. We should return the Terms of Service and Privacy Notice links to separate lines, but increase the spacing between them. 1em margin? 200% line-height? I'm not sure what is standard in in-content prefs, but the image linked in URL shows the right spacing.
Attachment #8634380 - Flags: review?(markh)
Attachment #8634380 - Flags: review?(markh) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e5fac6640496
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
I have reproduced this bug on Nightly 42.0a1 (2015-07-15) on ubuntu 14.04 LTS, 32 bit! The bug's fix is now verified on Latest Beta 42.0b3! Build ID: 20151001142456 User Agent: Mozilla/5.0 (X11; Linux i686; rv:42.0) Gecko/20100101 Firefox/42.0 [testday-20151002]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: