1184179 - Improve the about accounts page because Welcome is not always appropriate

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: Current on left, proposed on right

Improve the about:accounts page because Welcome is not always appropriate when you are signing in to Sync. See attached.

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1184179.patch

Comment 2

[Edouard Oger [:eoger]]

Attachment: bug-1184179.patch

oops, a new line managed to slip by

Comment 3

[Ryan Feeley [:rfeeley]]

Looks great!

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8634420 [details] [diff] [review]
bug-1184179.patch

Review of attachment 8634420 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/aboutaccounts/aboutaccounts.js
@@ +97,5 @@
>  
> +function updateDisplayedEmail(user) {
> +  let emailDiv = document.getElementById("email");
> +  if (emailDiv && user) {
> +    emailDiv.innerHTML = user.email;

I think we want .textContent - see https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML#Security_considerations

@@ -327,5 @@
>        // No action specified.
>        if (user) {
>          show("stage", "manage");
>          let sb = Services.strings.createBundle("chrome://browser/locale/syncSetup.properties");
> -        document.title = sb.GetStringFromName("manage.pageTitle");

We should remove the line above and the string itself (dxr tells me this is the only use of the string)

Comment 5

[Edouard Oger [:eoger]]

Attachment: bug-1184179.patch

Thanks for the feedback

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/654ba9f11688

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/654ba9f11688

Comment 8

[Md. Rahimul Islam]

I have successfully reproduce this bug on firefox aurora 41.0a2 (2015-07-15) (Build ID: 20150715004006)
with windows 7 (32 bit)

I found this fix on latest Aurora  42.0a1 (2015-08-11)

Mozilla/5.0 (Windows NT 6.1; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID : 20150811004008

[bugday-20150812]

Comment 9

[Mark Hammond [:markh] [:mhammond]]

(In reply to Md. Rahimul Islam from comment #8)
> I have successfully reproduce this bug on firefox aurora 41.0a2 (2015-07-15)
> (Build ID: 20150715004006)
> with windows 7 (32 bit)
> 
> I found this fix on latest Aurora  42.0a1 (2015-08-11)

Thanks very much!