1184226 - Peers that refuse to provide a client certificate cause assertion in TransportShutdown

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Martin Thomson [:mt:]]

This isn't a problem outside of debug builds, where it causes a crash, but we should handle this more gracefully.

Comment 1

[Martin Thomson [:mt:]]

Attachment: MozReview Request: Bug 1184226 - Updating transportlayerdtls logging levels, r?ekr

Bug 1184226 - Updating transportlayerdtls logging levels, r?ekr

Comment 2

[Martin Thomson [:mt:]]

Attachment: MozReview Request: Bug 1184226 - Disabling write on shutdown, r?ekr

Bug 1184226 - Disabling write on shutdown, r?ekr

Comment 3

[Eric Rescorla (:ekr)]

https://reviewboard.mozilla.org/r/13367/#review12001

LGTM with nit fixed

::: media/mtransport/transportlayerdtls.h:38
(Diff revision 1)
>  
>    void PacketReceived(const void *data, int32_t len);
>    int32_t Recv(void *buf, int32_t buflen);
>    int32_t Write(const void *buf, int32_t length);
> +  void SetEnabled(bool ena) { enabled_ = ena; }

NIT: bool enabled

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b33e3287066
https://hg.mozilla.org/integration/mozilla-inbound/rev/c82d87f445e3

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af0cd6e1245c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b33e3287066
https://hg.mozilla.org/mozilla-central/rev/c82d87f445e3
https://hg.mozilla.org/mozilla-central/rev/af0cd6e1245c

Comment 7

[Eric Rescorla (:ekr)]

Comment on attachment 8634283 [details]
MozReview Request: Bug 1184226 - Updating transportlayerdtls logging levels, r?ekr

This has already been reviewed and landed

Comment 8

[Eric Rescorla (:ekr)]

Comment on attachment 8634284 [details]
MozReview Request: Bug 1184226 - Disabling write on shutdown, r?ekr

This has already been reviewed and landed