If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Peers that refuse to provide a client certificate cause assertion in TransportShutdown

RESOLVED FIXED in Firefox 42

Status

()

Core
WebRTC: Networking
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mt, Assigned: mt)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
This isn't a problem outside of debug builds, where it causes a crash, but we should handle this more gracefully.
(Assignee)

Comment 1

2 years ago
Created attachment 8634283 [details]
MozReview Request: Bug 1184226 - Updating transportlayerdtls logging levels, r?ekr

Bug 1184226 - Updating transportlayerdtls logging levels, r?ekr
Attachment #8634283 - Flags: review?(ekr)
(Assignee)

Comment 2

2 years ago
Created attachment 8634284 [details]
MozReview Request: Bug 1184226 - Disabling write on shutdown, r?ekr

Bug 1184226 - Disabling write on shutdown, r?ekr
Attachment #8634284 - Flags: review?(ekr)
(Assignee)

Updated

2 years ago
Assignee: nobody → martin.thomson

Comment 3

2 years ago
https://reviewboard.mozilla.org/r/13367/#review12001

LGTM with nit fixed

::: media/mtransport/transportlayerdtls.h:38
(Diff revision 1)
>  
>    void PacketReceived(const void *data, int32_t len);
>    int32_t Recv(void *buf, int32_t buflen);
>    int32_t Write(const void *buf, int32_t length);
> +  void SetEnabled(bool ena) { enabled_ = ena; }

NIT: bool enabled

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b33e3287066
https://hg.mozilla.org/integration/mozilla-inbound/rev/c82d87f445e3

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/af0cd6e1245c
https://hg.mozilla.org/mozilla-central/rev/5b33e3287066
https://hg.mozilla.org/mozilla-central/rev/c82d87f445e3
https://hg.mozilla.org/mozilla-central/rev/af0cd6e1245c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

Comment 7

2 years ago
Comment on attachment 8634283 [details]
MozReview Request: Bug 1184226 - Updating transportlayerdtls logging levels, r?ekr

This has already been reviewed and landed
Attachment #8634283 - Flags: review?(ekr)

Comment 8

2 years ago
Comment on attachment 8634284 [details]
MozReview Request: Bug 1184226 - Disabling write on shutdown, r?ekr

This has already been reviewed and landed
Attachment #8634284 - Flags: review?(ekr)
You need to log in before you can comment on or make changes to this bug.