Closed Bug 1184226 Opened 4 years ago Closed 4 years ago

Peers that refuse to provide a client certificate cause assertion in TransportShutdown

Categories

(Core :: WebRTC: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: mt, Assigned: mt)

Details

Attachments

(2 files)

This isn't a problem outside of debug builds, where it causes a crash, but we should handle this more gracefully.
Bug 1184226 - Updating transportlayerdtls logging levels, r?ekr
Attachment #8634283 - Flags: review?(ekr)
Bug 1184226 - Disabling write on shutdown, r?ekr
Attachment #8634284 - Flags: review?(ekr)
Assignee: nobody → martin.thomson
https://reviewboard.mozilla.org/r/13367/#review12001

LGTM with nit fixed

::: media/mtransport/transportlayerdtls.h:38
(Diff revision 1)
>  
>    void PacketReceived(const void *data, int32_t len);
>    int32_t Recv(void *buf, int32_t buflen);
>    int32_t Write(const void *buf, int32_t length);
> +  void SetEnabled(bool ena) { enabled_ = ena; }

NIT: bool enabled
Comment on attachment 8634283 [details]
MozReview Request: Bug 1184226 - Updating transportlayerdtls logging levels, r?ekr

This has already been reviewed and landed
Attachment #8634283 - Flags: review?(ekr)
Comment on attachment 8634284 [details]
MozReview Request: Bug 1184226 - Disabling write on shutdown, r?ekr

This has already been reviewed and landed
Attachment #8634284 - Flags: review?(ekr)
You need to log in before you can comment on or make changes to this bug.