1184229 - mach mercurial-setup fails to update reviewboard

Status: RESOLVED FIXED

Description

[Nils Ohlmeier [:drno]]

I had my own checkout of the version-control-tools already.

After running 'mach mercurial-setup' for the first time mach had updated the bzexport to the copy of version-control-tools in my .mozbuild directory like this:

bzexport = /Users/nohlmeier/.mozbuild/version-control-tools/hgext/bzexport

But it did not touch the reviewboard one:

reviewboard = /Users/nohlmeier/checkouts/version-control-tools/hgext/reviewboard/client.py

Which turned out to be very bad, because on my next push to review board mach complain mid-flight that my version of the review board plugin is outdated.

Comment 1

[Gregory Szorc [:gps]]

A few people have hit this problem. Underlying cause is reviewboard is picking up Python modules from an earlier loaded and outdated version-control-tools repo. We should probably add detection to `mach mercurial-setup` for multiple version-control-tools checkouts.

Comment 2

[Gregory Szorc [:gps]]

Workaround is to consolidate to a single version-control-tools checkout, at least as far as hgrc references go.

Comment 3

[Gregory Szorc [:gps]]

Since a few people have been bitten by this, I'm going to see what I can do.

Comment 4

[Gregory Szorc [:gps]]

Created attachment 8635512 [details]
MozReview Request: Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r?smacleod

Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r?smacleod

Having multiple version-control-tools repositories references in your
hgrc could lead to one repository importing code from another, depending
on how sys.path modification works from version-control-tools
repositories. Detect it and issue a warning.

Comment 5

[Steven MacLeod [:smacleod]]

Comment on attachment 8635512 [details]
MozReview Request: Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r?smacleod

https://reviewboard.mozilla.org/r/13555/#review12313

Ship It!

Comment 6

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/integration/fx-team/rev/4beff7208d94ccecfe7c25d40e60a2d64a42da05
changeset:  4beff7208d94ccecfe7c25d40e60a2d64a42da05
user:       Gregory Szorc <[e-mail]>
date:       Mon Jul 27 13:44:39 2015 -0700
description:
Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r=smacleod

Having multiple version-control-tools repositories references in your
hgrc could lead to one repository importing code from another, depending
on how sys.path modification works from version-control-tools
repositories. Detect it and issue a warning.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4beff7208d94