mach mercurial-setup fails to update reviewboard

RESOLVED FIXED in Firefox 42

Status

()

Core
mach
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: drno, Assigned: gps)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
I had my own checkout of the version-control-tools already.

After running 'mach mercurial-setup' for the first time mach had updated the bzexport to the copy of version-control-tools in my .mozbuild directory like this:

bzexport = /Users/nohlmeier/.mozbuild/version-control-tools/hgext/bzexport

But it did not touch the reviewboard one:

reviewboard = /Users/nohlmeier/checkouts/version-control-tools/hgext/reviewboard/client.py

Which turned out to be very bad, because on my next push to review board mach complain mid-flight that my version of the review board plugin is outdated.
(Assignee)

Comment 1

2 years ago
A few people have hit this problem. Underlying cause is reviewboard is picking up Python modules from an earlier loaded and outdated version-control-tools repo. We should probably add detection to `mach mercurial-setup` for multiple version-control-tools checkouts.
(Assignee)

Comment 2

2 years ago
Workaround is to consolidate to a single version-control-tools checkout, at least as far as hgrc references go.
(Assignee)

Comment 3

2 years ago
Since a few people have been bitten by this, I'm going to see what I can do.
Assignee: nobody → gps
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 years ago
Created attachment 8635512 [details]
MozReview Request: Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r?smacleod

Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r?smacleod

Having multiple version-control-tools repositories references in your
hgrc could lead to one repository importing code from another, depending
on how sys.path modification works from version-control-tools
repositories. Detect it and issue a warning.
Attachment #8635512 - Flags: review?(smacleod)
Attachment #8635512 - Flags: review?(smacleod) → review+
Comment on attachment 8635512 [details]
MozReview Request: Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r?smacleod

https://reviewboard.mozilla.org/r/13555/#review12313

Ship It!
(Assignee)

Comment 6

2 years ago
url:        https://hg.mozilla.org/integration/fx-team/rev/4beff7208d94ccecfe7c25d40e60a2d64a42da05
changeset:  4beff7208d94ccecfe7c25d40e60a2d64a42da05
user:       Gregory Szorc <gps@mozilla.com>
date:       Mon Jul 27 13:44:39 2015 -0700
description:
Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r=smacleod

Having multiple version-control-tools repositories references in your
hgrc could lead to one repository importing code from another, depending
on how sys.path modification works from version-control-tools
repositories. Detect it and issue a warning.
https://hg.mozilla.org/mozilla-central/rev/4beff7208d94
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.