1184231 - [Control Center] open=true attribute disappears when closing a site permission dropdown

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Tim Taubert [:ttaubert] (inactive)]

When clicking a per-site permission dropdown and clicking it again to close it we remove the open=true attribute from the #identity-box and thus its "hover" state.

[Tracking Requested - why for this release]:

It's more a visual defect, not a serious bug but I think we should fix it.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1184231-Control-Center-open-true-attribute-shoul.patch

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/62c9203666d6

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/62c9203666d6

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8634227 [details] [diff] [review]
0001-Bug-1184231-Control-Center-open-true-attribute-shoul.patch

Approval Request Comment
[Feature/regressing bug #]: Long-standing bug.
[User impact if declined]: Identity box becomes visually de-selected when fiddling around with per-site permissions in the control center.
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: Verrrry low risk.
[String/UUID change made/needed]: None.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8634227 [details] [diff] [review]
0001-Bug-1184231-Control-Center-open-true-attribute-shoul.patch

Low risk, so approved.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3c77c1a7ae0b

Comment 7

[Catalin Varga [QA][:VarCat]]

Verified as fixed using:

FF 42 Build Id: 20150728030209
FF 41 Build Id: 20150729004002

OS: Win 7 x64, Ubuntu 14.04 x32, Mac Os X 10.10.4