1184284 - 1,200 instances of "NS_ENSURE_TRUE(txToRemove) failed" emitted from docshell/shistory/nsSHistory.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Eric Rahm [:erahm]]

> 1189 [NNNNN] WARNING: NS_ENSURE_TRUE(txToRemove) failed: file docshell/shistory/nsSHistory.cpp, line 1318

This warning [1] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:297
> mozilla-central_ubuntu64_vm-debug_test-mochitest-3-bm115-tests1-linux64-build21.txt:124
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm51-tests1-linux64-build0.txt:113
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm53-tests1-linux64-build28.txt:83
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm121-tests1-linux64-build0.txt:80
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:79
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:58
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-2-bm120-tests1-linux64-build0.txt:57
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:56
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:54
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:53
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:53
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:30
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm122-tests1-linux64-build19.txt:11
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm122-tests1-linux64-build17.txt:6
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:6
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm123-tests1-linux64-build2.txt:5
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:5
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm121-tests1-linux64-build1.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm53-tests1-linux64-build27.txt:3
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm52-tests1-linux64-build11.txt:2
> mozilla-central_ubuntu64_vm-debug_test-reftest-3-bm52-tests1-linux64-build0.txt:1
> mozilla-central_ubuntu64_vm-debug_test-reftest-1-bm54-tests1-linux64-build2.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-push-bm68-tests1-linux64-build20.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-3-bm115-tests1-linux64-build9.txt:1

It shows up in 188 tests. A few of the most prevalent:

> 256 - layout/base/tests/test_reftests_with_caret.html
> 166 - dom/tests/mochitest/ajax/jquery/test_jQuery.html
> 80 - dom/imptests/html/dom/nodes/test_Document-createElement-namespace.html
> 58 - docshell/test/navigation/test_sessionhistory.html
> 32 - editor/composer/test/test_bug519928.html
> 28 - editor/libeditor/tests/test_root_element_replacement.html
> 24 - file:///builds/slave/test/build/tests/reftest/tests/dom/base/crashtests/828903.html
> 22 - toolkit/devtools/server/tests/mochitest/test_inspector-dead-nodes.html
> 20 - toolkit/content/tests/widgets/test_videocontrols_video_direction.html
> 20 - toolkit/content/tests/widgets/test_videocontrols_audio_direction.html

[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/docshell/shistory/nsSHistory.cpp#l1318

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I could live without that warning.

Comment 2

[Eric Rahm [:erahm]]

Attachment: txToRemove warning from nsSHistory::RemoveDuplicate

Comment 3

[Eric Rahm [:erahm]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/47235d46727da52da2158adc2f5a2a3e66b46a45
changeset:  47235d46727da52da2158adc2f5a2a3e66b46a45
user:       Eric Rahm <[e-mail]>
date:       Wed Jul 15 13:18:57 2015 -0700
description:
Bug 1184284 - Remove txToRemove warning from nsSHistory::RemoveDuplicate. r=smaug

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/47235d46727d