Closed Bug 1184295 Opened 4 years ago Closed 4 years ago

1,100 instances of "have unconstrained inline-size; this should only result from very large sizes, not attempts at intrinsic inline-size calculation: 'aContainingBlockISize != NS_UNCONSTRAINEDSIZE'" emitted from layout/base/nsLayoutUtils.cpp during linux6

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: erahm, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #525100 +++

> 1054 [NNNNN] WARNING: have unconstrained inline-size; this should only result from very large sizes, not attempts at intrinsic inline-size calculation: 'aContainingBlockISize != NS_UNCONSTRAINEDSIZE', file layout/base/nsLayoutUtils.cpp, line 4727

This warning [1], introduced in bug 525100, shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:432
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:432
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm123-tests1-linux64-build2.txt:48
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm121-tests1-linux64-build1.txt:48
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:40
> mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm53-tests1-linux64-build27.txt:40
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm53-tests1-linux64-build28.txt:14

It shows up in 12 tests. A few of the most prevalent:

> 864 - layout/style/test/test_logical_properties.html
> 40 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/orthogonal-floats-1b.html
> 40 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/floats/orthogonal-floats-1a.html
> 16 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/tables/fixed-table-layout-009-vlr.html
> 16 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/1172774-percent-padding-4.html
> 16 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/1172774-percent-padding-3.html
> 16 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/1172774-percent-margin-4.html
> 16 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/1172774-percent-margin-3.html
> 9 - file:///builds/slave/test/build/tests/reftest/tests/layout/base/crashtests/265986-1.html
> 8 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/tables/fixed-table-layout-009-vrl.html

[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/layout/base/nsLayoutUtils.cpp#l4727
We're seeing this in b2g tests as well.
Considering this is only showing up in 12 tests I'm inclined to think it's indicating a real issue.

Cameron, we're seeing a lot of:

> WARNING: have unconstrained inline-size; this should only result from very large sizes, not attempts at intrinsic inline-size calculation: 'aContainingBlockISize != NS_UNCONSTRAINEDSIZE'

generated by |layout/style/test/test_logical_properties.html| [1], does this seem legit or is it indicating an error we need to fix (I didn't see any obviously large sizes)?

[1] https://hg.mozilla.org/mozilla-central/annotate/e7434cafdf2f/layout/style/test/test_logical_properties.html
Flags: needinfo?(cam)
Might be more useful to ask Jonathan.
Flags: needinfo?(jfkthame)
The warnings here occur because the container of the test <div> has unconstrained height when we're reflowing, which translates to unconstrained containing-block isize when the writing mode is vertical. We can suppress them by ensuring the <div> has a container with specified dimensions; this shouldn't affect what the tests here are actually checking.
Attachment #8638956 - Flags: review?(cam)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8638956 [details] [diff] [review]
Ensure the containing block has a constrained size during logical-properties tests, to suppress unconstrained-isize warnings

Review of attachment 8638956 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Jonathan.
Attachment #8638956 - Flags: review?(cam) → review+
Flags: needinfo?(cam)
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3741aa98b8918c7d18116cd42f9f5c82d6e13048
changeset:  3741aa98b8918c7d18116cd42f9f5c82d6e13048
user:       Jonathan Kew <jkew@mozilla.com>
date:       Mon Jul 27 08:06:46 2015 +0100
description:
Bug 1184295 - Ensure the containing block has a constrained size during logical-properties tests, to suppress unconstrained-isize warnings. r=heycam
Flags: needinfo?(jfkthame)
https://hg.mozilla.org/mozilla-central/rev/3741aa98b891
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.