Closed
Bug 1184302
Opened 10 years ago
Closed 10 years ago
Check if a user is logged in when cancelling a job in TH UI itself
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vaibhav1994, Assigned: vaibhav1994)
Details
Attachments
(1 file)
Right now, when a user is not logged in, we still send a request from the front-end, which is rejected by the back-end django server. We can check if the user is logged in the Treeherder front-end and save an extra request.
|
Assignee | |
Comment 1•10 years ago
|
||
Ed, could you please review this patch?
Attachment #8634336 -
Flags: review?(emorley)
|
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8634336 [details] [review]
fix for #1184302
Thank you - looks great! :-)
Attachment #8634336 -
Flags: review?(emorley) → review+
|
||
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/22ffbe8612571a046ba0514e4102a768439e740a
Bug 1184302-Check if a user is logged in early on job cancel request
https://github.com/mozilla/treeherder/commit/449f36ccc1c99cb2e55ecd8e565d15d960a035a4
Merge pull request #766 from vaibhavmagarwal/cancel-fix
Bug 1184302 - Check if a user is logged in early on job cancel request
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•