Closed
Bug 1184312
Opened 7 years ago
Closed 7 years ago
Remove old tracking protection/MCB shield
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
Tracking | Status | |
---|---|---|
firefox42 | --- | verified |
People
(Reporter: keeler, Assigned: bgrins)
References
Details
(Whiteboard: [fxprivacy] [campaign])
Attachments
(2 files, 1 obsolete file)
42.38 KB,
image/png
|
Details | |
27.82 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
STR: enable tracking protection (set privacy.trackingprotection.enabled to true) visit a site with tracking elements (e.g. http://www.nytimes.com/ ) two shield icons appear (both the popup notification one with the chevron on the right side and the site identity one to the left of the globe icon)
Comment 1•7 years ago
|
||
I also see this problem on irccloud.mozilla.com.
Comment 2•7 years ago
|
||
That's expected for now as I'm working on bug 1175702, the last things that keeps us from removing the old MCB/TP shield. They'll both find a new home in the control center with Firefox 42.
Updated•7 years ago
|
Component: General → Location Bar
Updated•7 years ago
|
Flags: firefox-backlog+
Priority: -- → P2
Whiteboard: [fxprivacy]
Assignee | ||
Comment 5•7 years ago
|
||
Relevant existing tests for the bad content doorhanger: https://dxr.mozilla.org/mozilla-central/search?q=PopupNotifications.getNotification%28%22bad-content%22&case=false
Updated•7 years ago
|
Summary: tracking protection shield shows up twice → Remove old tracking protection/MCB shield
Updated•7 years ago
|
Points: --- → 3
Updated•7 years ago
|
Flags: qe-verify?
Comment 6•7 years ago
|
||
Hi Paolo, does this bug require QA verification?
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 42.3 - Aug 10
Flags: needinfo?(paolo.mozmail)
Priority: P2 → P1
Updated•7 years ago
|
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
Comment 7•7 years ago
|
||
Yeah, we should test that we don't have two shields in the location bar when tracking protection and/or Mixed Content Blocking are active. By the way, other people should feel free to take the bug if they beat me to it.
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(paolo.mozmail)
Comment 8•7 years ago
|
||
Moving back to 'P2' and out of this iteration to free up time for other higher priority work.
Assignee: paolo.mozmail → nobody
Status: ASSIGNED → NEW
Iteration: 42.3 - Aug 10 → ---
Priority: P1 → P2
Whiteboard: [fxprivacy] [campaign] → [fxprivacy]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Updated•7 years ago
|
Iteration: --- → 42.3 - Aug 10
Priority: P2 → P1
QA Contact: mwobensmith
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 9•7 years ago
|
||
First version of code removal, based off of the WIP patch in Bug 1175702. Handling test updates in Bug 1186925
Assignee | ||
Comment 10•7 years ago
|
||
Ongoing try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a9be525283c Note that this depends on patches from Bug 1175702 and 1186925.
Attachment #8642670 -
Attachment is obsolete: true
Attachment #8644703 -
Flags: review?(ttaubert)
Comment 11•7 years ago
|
||
Comment on attachment 8644703 [details] [diff] [review] remove-bad-content.patch Review of attachment 8644703 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! We should remove the old icons too: (../shared/bad-content-blocked-16.png) (../shared/bad-content-blocked-16@2x.png) (../shared/bad-content-blocked-64.png) (../shared/bad-content-blocked-64@2x.png) (../shared/bad-content-unblocked-16.png) (../shared/bad-content-unblocked-16@2x.png) (../shared/bad-content-unblocked-64.png) (../shared/bad-content-unblocked-64@2x.png) bad-content-blocked-16.png seems to be used by the old not-in-content preferences file browser/components/preferences/privacy.xul. We should probably just switch that to the new TP icon, they're going away somewhat soon anyway. r=me with the icons removed.
Attachment #8644703 -
Flags: review?(ttaubert) → review+
Comment 13•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5ea0445e2eff
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment 14•7 years ago
|
||
Verified fixed FF 42.0a2 (2015-08-25) Win 7, Ubuntu 14.04, OS X 10.10.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•