1184385 - Implement an equivalent of std::tie in mfbt/Tuple.h

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Seth Fowler [:seth] [:s2h]]

std::tie is really handy for making code that involves std::pair more readable. In addition it's handy generally for working with tuples. Let's implement an equivalent.

Comment 1

[Botond Ballo [:botond] [away until Jun 24]]

Attachment: MozReview Request: Bug 1184385 - Add a Tie() utility function for tuples (the equivalent of std::tie()) to MFBT. r=froydnj

Bug 1184385 - Add a Tie() utility function for tuples (the equivalent of std::tie()) to MFBT. r=froydnj

Comment 2

[Botond Ballo [:botond] [away until Jun 24]]

Build-only Try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d125020356c

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8635729 [details]
MozReview Request: Bug 1184385 - Add a Tie() utility function for tuples (the equivalent of std::tie()) to MFBT. r=froydnj

https://reviewboard.mozilla.org/r/13601/#review12245

::: mfbt/tests/TestTuple.cpp:151
(Diff revision 1)
> +  return true;

Since we want Tie to work automatically with conversion, is it worth adding a test that actually requires conversion when assigning to the elements?  Or writing a standalone test to ensure converting elements works?

Comment 4

[Botond Ballo [:botond] [away until Jun 24]]

Comment on attachment 8635729 [details]
MozReview Request: Bug 1184385 - Add a Tie() utility function for tuples (the equivalent of std::tie()) to MFBT. r=froydnj

Bug 1184385 - Add a Tie() utility function for tuples (the equivalent of std::tie()) to MFBT. r=froydnj

Comment 5

[Botond Ballo [:botond] [away until Jun 24]]

Comment on attachment 8635729 [details]
MozReview Request: Bug 1184385 - Add a Tie() utility function for tuples (the equivalent of std::tie()) to MFBT. r=froydnj

Updated test to add a part involving conversions. Carrying r+.

New build-only Try push:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4e99b80b5ed

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1804dea1fadd

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1804dea1fadd