1184538 - [Ruleview] values are being autocompleted wrong when I press Shift+Up/Down while the cursor is placed in the middle of the rule value

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[arni2033]

Attachment: [Ruleview] rule vaules are being autocompleted Wrong.webm

STR:
1. Open Inspector -> sidebar -> Rules tab
2. Create new rule "background: darkblue;"
3. Place cursor between "l" and "u" in "darkblue"
4. Press Shift+Up/Down
5. (optional) GoTo step 3

Result:
Value is being autocompleted so I get "darkblueueueue". The same applies to rule names.

Expectation:
In this case Shift+Up/Down hotkeys should work just like Up/Down - to move cursor to the beginning/end of the value/rule

Comment 1

[Julian Descottes [:jdescottes]]

Inspector bug triage, filter on CLIMBING SHOES.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1184538 - [devtools] Shift+Up|Down should not trigger autocomplete in InplaceEditor. r=#devtools.

Those were triggering specific issues as they do cause
characters to be selected in the input, which makes it
looks like a regular completion to the maybeSuggestCompletion
method. Other selecting combination (e.g. Shift+Right|Home)
didn't suffer from this because they're triggering a different
code path.
This adds a few test cases to make sure we're handling all those
as we should.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/925a7c634e8c
[devtools] Shift+Up|Down should not trigger autocomplete in InplaceEditor. r=devtools-reviewers,jdescottes.

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_rules_gridline-names-are-shown-correctly.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f10cdccac8534641ee045f96d875dc5ae9fda817

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=925a7c634e8c8afd0bb828929fcc078041fe34a0&selectedTaskRun=L2vATyMuTZG3dCEGY18gCA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=490637671&repo=autoland&lineNumber=4066

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68aebe687205
[devtools] Shift+Up|Down should not trigger autocomplete in InplaceEditor. r=devtools-reviewers,jdescottes.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/68aebe687205