1184555 - View Later extension should show success

Status: RESOLVED WONTFIX

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

In Twitter, open a link and tap View Later in the share menu. Nothing happens. I have no idea if it worked or not until I open Firefox later.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

We (UX) decided not to do this.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Stefan Arentz [:st3fan] from comment #1)
> We (UX) decided not to do this.

Any comments as to why not? I tried "View Later" but had no idea that anything happened, or what I should expect to do next.

Comment 3

[Richard Newman [:rnewman]]

In short: because Send actions don't show confirmation (or any UI, most of the time) on iOS; try it with some of the others. Share extensions do, Send extensions don't.

Also it's essentially impossible for this to fail.

If we get external feedback about this we might change our minds, but for the moment we're following platform conventions.

Comment 4

[Richard Newman [:rnewman]]

Robin would like to do this. Mocks:

http://invis.io/DE3BHFHMW (Success)
http://invis.io/293LMTPC3 (Please try again)

Not a heavy weight of strings, so perhaps we can get those in now?

Comment 5

[Robin Andersen [:tecgirl]]

Attachment: Send-View-Toasts.png

Layout for toast placement.

Comment 6

[Robin Andersen [:tecgirl]]

Attachment: toastAssets.zip

Comment 7

[Stephan Leroux [:sleroux]]

So turns out this actually isn't possible. Action extensions such as View Later require you to modally present your view if you want to use UI. This is the same animation that happens when you tap SendTo and you see the list of devices animate up from the bottom. There doesn't seem to be a way to customize this. Also, because it's presented modally with what looks like a UINavigationController, we can't just make our view invisible so we don't see the modal and see the content behind it because the app you were looking at goes away after the transition is complete :/

Comment 8

[Stephan Leroux [:sleroux]]

I've pushed up my WIP code for this branch here: https://github.com/mozilla/firefox-ios/tree/sleroux/Bug1184555-ViewLaterSuccessToast

Comment 9

[Stephan Leroux [:sleroux]]

Demoting from 1.1 and re-nom it for UX consideration