1184564 - Remove jsval

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Part 1 - XPConnect

jsval is a typedef for JS::Value so this is pretty straight-forward.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 2 - dom/ and storage/

This patch is surprisingly small but it's all we need to build, so..

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 3 - CTypes

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 4 - JS

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Part 5 - Remove typedef

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8634730 [details] [diff] [review]
Part 2 - dom/ and storage/

r=me

Comment 6

[Tooru Fujisawa [:arai]]

Comment on attachment 8634732 [details] [diff] [review]
Part 3 - CTypes

Review of attachment 8634732 [details] [diff] [review]:
-----------------------------------------------------------------

https://dxr.mozilla.org/mozilla-central/source/js/src/ctypes/CTypes.cpp#6379
>   AutoValueVector argTypes(cx);
>   RootedObject arrayObj(cx, nullptr);
> 
>   if (args.length() == 3) {
>     // Prepare an array of jsvals for the arguments.

As other comments are fixed, would you change "jsvals" to "Values" here for consistency?

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fc4e125b2b7
https://hg.mozilla.org/integration/mozilla-inbound/rev/78740e4f4998
https://hg.mozilla.org/integration/mozilla-inbound/rev/88d00f2bce22
https://hg.mozilla.org/integration/mozilla-inbound/rev/52b5efb72cc9

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/586a705d85ae

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5fc4e125b2b7
https://hg.mozilla.org/mozilla-central/rev/78740e4f4998
https://hg.mozilla.org/mozilla-central/rev/88d00f2bce22
https://hg.mozilla.org/mozilla-central/rev/52b5efb72cc9
https://hg.mozilla.org/mozilla-central/rev/586a705d85ae

Comment 10

[Florian Scholz (Open Web Docs)]

arai updated:
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_Reference/JS::Value

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_NumberValue
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetNaNValue
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetPositiveInfinityValue

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetEmptyStringValue
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetReservedSlot
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_IsStopIteration

Comment 11

[Jan de Mooij [:jandem]]

(In reply to Florian Scholz [:fscholz] (MDN) from comment #10)
> arai updated:

Thanks arai. Much appreciated.