Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

({dev-doc-complete})

unspecified
mozilla42
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(5 attachments)

(Assignee)

Description

3 years ago
Created attachment 8634728 [details] [diff] [review]
Part 1 - XPConnect

jsval is a typedef for JS::Value so this is pretty straight-forward.
Attachment #8634728 - Flags: review?(bobbyholley)
(Assignee)

Comment 1

3 years ago
Created attachment 8634730 [details] [diff] [review]
Part 2 - dom/ and storage/

This patch is surprisingly small but it's all we need to build, so..
Attachment #8634730 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

3 years ago
Created attachment 8634732 [details] [diff] [review]
Part 3 - CTypes
Attachment #8634732 - Flags: review?(arai.unmht)
(Assignee)

Comment 3

3 years ago
Created attachment 8634733 [details] [diff] [review]
Part 4 - JS
Attachment #8634733 - Flags: review?(evilpies)
(Assignee)

Comment 4

3 years ago
Created attachment 8634734 [details] [diff] [review]
Part 5 - Remove typedef
Attachment #8634734 - Flags: review?(jwalden+bmo)
Comment on attachment 8634730 [details] [diff] [review]
Part 2 - dom/ and storage/

r=me
Attachment #8634730 - Flags: review?(bzbarsky) → review+
Attachment #8634728 - Flags: review?(bobbyholley) → review+
Attachment #8634734 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 8634732 [details] [diff] [review]
Part 3 - CTypes

Review of attachment 8634732 [details] [diff] [review]:
-----------------------------------------------------------------

https://dxr.mozilla.org/mozilla-central/source/js/src/ctypes/CTypes.cpp#6379
>   AutoValueVector argTypes(cx);
>   RootedObject arrayObj(cx, nullptr);
> 
>   if (args.length() == 3) {
>     // Prepare an array of jsvals for the arguments.

As other comments are fixed, would you change "jsvals" to "Values" here for consistency?
Attachment #8634732 - Flags: review?(arai.unmht) → review+
Attachment #8634733 - Flags: review?(evilpies) → review+
(Assignee)

Updated

3 years ago
Keywords: leave-open
(Assignee)

Updated

3 years ago
Keywords: leave-open
Keywords: dev-doc-needed
(Assignee)

Comment 11

3 years ago
(In reply to Florian Scholz [:fscholz] (MDN) from comment #10)
> arai updated:

Thanks arai. Much appreciated.
You need to log in before you can comment on or make changes to this bug.