Closed
Bug 1184564
Opened 9 years ago
Closed 9 years ago
Remove jsval
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
(Keywords: dev-doc-complete)
Attachments
(5 files)
43.58 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
7.78 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
78.26 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
88.74 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
904 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
jsval is a typedef for JS::Value so this is pretty straight-forward.
Attachment #8634728 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 1•9 years ago
|
||
This patch is surprisingly small but it's all we need to build, so..
Attachment #8634730 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8634732 -
Flags: review?(arai.unmht)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8634733 -
Flags: review?(evilpies)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8634734 -
Flags: review?(jwalden+bmo)
Comment 5•9 years ago
|
||
Comment on attachment 8634730 [details] [diff] [review] Part 2 - dom/ and storage/ r=me
Attachment #8634730 -
Flags: review?(bzbarsky) → review+
Updated•9 years ago
|
Attachment #8634728 -
Flags: review?(bobbyholley) → review+
Updated•9 years ago
|
Attachment #8634734 -
Flags: review?(jwalden+bmo) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8634732 [details] [diff] [review] Part 3 - CTypes Review of attachment 8634732 [details] [diff] [review]: ----------------------------------------------------------------- https://dxr.mozilla.org/mozilla-central/source/js/src/ctypes/CTypes.cpp#6379 > AutoValueVector argTypes(cx); > RootedObject arrayObj(cx, nullptr); > > if (args.length() == 3) { > // Prepare an array of jsvals for the arguments. As other comments are fixed, would you change "jsvals" to "Values" here for consistency?
Attachment #8634732 -
Flags: review?(arai.unmht) → review+
Updated•9 years ago
|
Attachment #8634733 -
Flags: review?(evilpies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fc4e125b2b7 https://hg.mozilla.org/integration/mozilla-inbound/rev/78740e4f4998 https://hg.mozilla.org/integration/mozilla-inbound/rev/88d00f2bce22 https://hg.mozilla.org/integration/mozilla-inbound/rev/52b5efb72cc9
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Updated•9 years ago
|
Keywords: dev-doc-needed
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5fc4e125b2b7 https://hg.mozilla.org/mozilla-central/rev/78740e4f4998 https://hg.mozilla.org/mozilla-central/rev/88d00f2bce22 https://hg.mozilla.org/mozilla-central/rev/52b5efb72cc9 https://hg.mozilla.org/mozilla-central/rev/586a705d85ae
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment 10•9 years ago
|
||
arai updated: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_Reference/JS::Value https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_NumberValue https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetNaNValue https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetPositiveInfinityValue https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetEmptyStringValue https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetReservedSlot https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_IsStopIteration
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Comment 11•9 years ago
|
||
(In reply to Florian Scholz [:fscholz] (MDN) from comment #10) > arai updated: Thanks arai. Much appreciated.
You need to log in
before you can comment on or make changes to this bug.
Description
•