Closed Bug 1184594 Opened 9 years ago Closed 7 years ago

git 'repo' is not deployed correctly on build machines managed by buildbot

Categories

(Release Engineering :: General, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: hwine, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

issue worked around in bug 1184422 comment 2

However, that needs a real fix, so we can resume mirroring of 'repo' again.

One suspect is the buildbot modification at:
 http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/b2g_config.py#1617
which may explain why this is a releng only issue
Blocks: 1184595
Attached patch pin-repo.diffSplinter Review
As Hal mentioned, repo tries to self-update if if detects that we are on a detached head. This is the case when you checkout using a tag. Repo's code parses .git/HEAD and find whether it starts with "ref:".

This is a workaround to prevent repo self-upgrading itself.

`git checkout -B tmp_branch $tag_name` creates a temporary branch based on a revision we need. -B ensures that we force it to create a new branch (in case we don't clobber and run it twice)
Assignee: nobody → rail
Attachment #8637332 - Flags: review?(hwine)
This is what I had mid-build on https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ec8824e6961

[cltbld@try-linux64-spot-050.try.releng.use1.mozilla.com repo]$ pwd
/builds/slave/b2g_try_emu_dep-00000000000000/build/.repo/repo
[cltbld@try-linux64-spot-050.try.releng.use1.mozilla.com repo]$ git status
On branch tmp_moz_branch
nothing to commit, working directory clean
[cltbld@try-linux64-spot-050.try.releng.use1.mozilla.com repo]$ git show-branch --sha1-name tmp_moz_branch
[666d534] Ensure HEAD is correct when skipping remote fetch
[cltbld@try-linux64-spot-050.try.releng.use1.mozilla.com repo]$ git show-branch --sha1-name v1.12.16
[666d534] Ensure HEAD is correct when skipping remote fetch
Comment on attachment 8637332 [details] [diff] [review]
pin-repo.diff

Review of attachment 8637332 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm; r+ with the addition of the "get back to stable" bug as being blocked by this.

The following still shows in the log, and likely will until upstream is fixed for the reason we pinned:
     INFO -  info: A new version of repo is available
     INFO -  warning: project 'repo' branch 'master' is not signed
     INFO -  warning: Skipped upgrade to unverified version

Of most concern is the attempt to update to branch 'master' -- we should be using 'stable' (which has signed tags).
Attachment #8637332 - Flags: review?(hwine) → review+
Comment on attachment 8637332 [details] [diff] [review]
pin-repo.diff

backout 

https://hg.mozilla.org/integration/mozilla-inbound/rev/07ff7cf012bc

https://hg.mozilla.org/build/mozharness/rev/3ae81f4458ef


Errors received:
The directory '/home/worker/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Return code: 0
IOError: [Errno 2] No such file or directory: '/home/worker/workspace/gecko/testing/taskcluster/scripts/builder/oauth.txt'
Return code: 128
128 not in success codes: [0]
Halting on failure while running ['git', 'checkout', '-B', 'tmp_moz_branch', 'stable']
Running post_fatal callback...
Exiting 2 

https://tools.taskcluster.net/task-inspector/#_H85CAQ6T8-jYZI84z4efw/0
Attachment #8637332 - Flags: checked-in+ → checked-in-
back to the pool, I haven't touched this for a long time
Assignee: rail → nobody
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: