1184677 - 1,200 instances of "'!aCharRect.width'" and '!aCharRect.height" emitted from ContentCacheInChild::CacheTextRects during linux64 debug testing

Status: RESOLVED WORKSFORME

(Core :: Widget, defect)

Description

[Eric Rahm [:erahm]]

> 857 [NNNNN] WARNING: '!aCharRect.width', file widget/ContentCache.cpp, line 317

This warning [1] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm115-tests1-linux64-build34.txt:523
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm122-tests1-linux64-build8.txt:116
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm117-tests1-linux64-build17.txt:59
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm54-tests1-linux64-build0.txt:53
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm113-tests1-linux64-build0.txt:45
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm67-tests1-linux64-build3.txt:31
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm54-tests1-linux64-build15.txt:19
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm120-tests1-linux64-build1.txt:6
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm67-tests1-linux64-build39.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm118-tests1-linux64-build16.txt:1

It shows up in 197 tests. A few of the most prevalent:

> 274 - editor/libeditor/tests/test_bug795785.html
> 89 - editor/libeditor/tests/test_bug449243.html
> 44 - dom/browser-element/mochitest/test_browserElement_oop_CopyPaste.html
> 24 - editor/libeditor/tests/test_bug638596.html
> 21 - editor/libeditor/tests/test_bug674861.html
> 18 - editor/libeditor/tests/test_dom_input_event_on_htmleditor.html
> 18 - editor/libeditor/tests/test_bug514156.html
> 18 - editor/libeditor/tests/test_bug1109465.html
> 18 - dom/html/test/test_bug430351.html
> 13 - dom/tests/mochitest/bugs/test_bug346659.html

> 334 [NNNNN] WARNING: '!aCharRect.height', file widget/ContentCache.cpp, line 314

This warning [2] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm122-tests1-linux64-build8.txt:116
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm54-tests1-linux64-build0.txt:53
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm117-tests1-linux64-build17.txt:43
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm115-tests1-linux64-build34.txt:29
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm67-tests1-linux64-build3.txt:27
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm113-tests1-linux64-build0.txt:27
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm54-tests1-linux64-build15.txt:21
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm120-tests1-linux64-build0.txt:7
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm67-tests1-linux64-build39.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm120-tests1-linux64-build1.txt:3
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm122-tests1-linux64-build7.txt:3
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm118-tests1-linux64-build16.txt:1

It shows up in 181 tests. A few of the most prevalent:

> 44 - dom/browser-element/mochitest/test_browserElement_oop_CopyPaste.html
> 13 - dom/tests/mochitest/bugs/test_bug346659.html
> 11 - browser/base/content/test/general/browser_clipboard.js
> 10 - dom/html/test/test_iframe_sandbox_navigation2.html
> 9 - docshell/test/navigation/test_not-opener.html
> 8 - docshell/test/navigation/test_sessionhistory.html
> 8 - docshell/test/navigation/test_reserved.html
> 6 - dom/tests/mochitest/bugs/test_bug458091.html
> 6 - dom/html/test/test_window_open_close.html
> 5 - dom/tests/mochitest/geolocation/test_manyWindows.html

[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/widget/ContentCache.cpp#l317
[2] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/widget/ContentCache.cpp#l314

Comment 1

[Eric Rahm [:erahm]]

..and one more warning from that function

> 364 [NNNNN] WARNING: '!textRect.mSucceeded', file widget/ContentCache.cpp, line 308

This warning [1] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm115-tests1-linux64-build37.txt:157
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm53-tests1-linux64-build5.txt:136
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build14.txt:48
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm53-tests1-linux64-build4.txt:12
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm54-tests1-linux64-build9.txt:10
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm115-tests1-linux64-build5.txt:1

It shows up in 20 tests. A few of the most prevalent:

> 125 - layout/generic/test/test_bug496275.html
> 65 - editor/libeditor/tests/test_bug674861.html
> 35 - dom/html/test/test_bug460568.html
> 22 - editor/libeditor/tests/test_bug570144.html
> 22 - editor/libeditor/tests/test_bug417418.html
> 21 - editor/libeditor/tests/test_bug1026397.html
> 17 - editor/libeditor/tests/test_bug449243.html
> 13 - dom/html/test/test_bug430392.html
> 12 - dom/browser-element/mochitest/test_browserElement_oop_CopyPaste.html
> 9 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/bugs/503531-1.html

[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/widget/ContentCache.cpp#l308

Comment 2

[Eric Rahm [:erahm]]

Attachment: Remove warnings from ContentCacheInChild::QueryCharRect

Given the verbosity of these warnings and our proper handling of the error
conditions it seems like we can just remove them. Masayuki, what do you think?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8635054 [details] [diff] [review]
Remove warnings from ContentCacheInChild::QueryCharRect

These warnings shouldn't be removed because the causes should be fixed before shipping e10s. (The warnings must detect bugs of ContentEventHandler.)

We need to investigate what causes the failures.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

And I think that we should separate this bug to failure of NS_QUERY_TEXT_RECT and the others.

Comment 5

[Eric Rahm [:erahm]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #4)
> And I think that we should separate this bug to failure of
> NS_QUERY_TEXT_RECT and the others.

Sure I'll split it out.

Comment 6

[Andrew McCreight [:mccr8]]

I don't see this in the top 100 most frequent warnings on Linux64.