Closed Bug 1184708 Opened 4 years ago Closed 4 years ago

private browsing progress bar sometimes orange at first

Categories

(Firefox for Android :: Theme and Visual Design, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox41 --- unaffected
firefox42 --- fixed
fennec 42+ ---

People

(Reporter: c.ascheberg, Assigned: mcomella)

References

Details

Attachments

(1 file)

The progress bar in private browsing tabs sometimes still has orange color at first, then switches to purple during further progress. The color changes to purple after the first time the progress bar stands still for a short moment.
tracking-fennec: --- → ?
I can't reliably reproduce this.

The color change occurs in BrowserApp.onTabChanged for both LOCATION_CHANGE and SELECTED events.

I didn't realize this was a fall-through and originally intended this to be for SELECTED events only. What's probably happening is a page starts loading in normal browsing, we open a new private tab, start loading a page, and we receive the LOCATION_CHANGE event for the normal browsing tab, changing the color of the progress bar to normal browsing until the LOCATION_CHANGE event occurs for private browsing.

To provide extra information, I initially thought, and then ruled out, that because the event happens asynchronously (via notifyListeners which places the Runnable on the the UiThread), it's possible there is a moment between the time when the tab is selected in Gecko and the UI updates (meaning the old progress bar is displayed), but then the toolbar text would be the old toolbar text (and I'd imagine the toolbar background color would be different as well).
Assignee: nobody → michael.l.comella
tracking-fennec: ? → 42+
Bug 1184708 - Set progress view private mode when visibility is changed. r=mhaigh
Attachment #8637610 - Flags: review?(mhaigh)
Attachment #8637610 - Flags: review?(mhaigh) → review+
Comment on attachment 8637610 [details]
MozReview Request: Bug 1184708 - Set progress view private mode when visibility is changed. r=mhaigh

https://reviewboard.mozilla.org/r/13951/#review12779

Seems sane to me :)
url:        https://hg.mozilla.org/integration/fx-team/rev/a2f1be1d0d5984ea94044a810299a2a91418a8c4
changeset:  a2f1be1d0d5984ea94044a810299a2a91418a8c4
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Wed Jul 22 19:03:47 2015 -0700
description:
Bug 1184708 - Set progress view private mode when visibility is changed. r=mhaigh
https://hg.mozilla.org/mozilla-central/rev/a2f1be1d0d59
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.