1184708 - private browsing progress bar sometimes orange at first

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Christian Ascheberg]

The progress bar in private browsing tabs sometimes still has orange color at first, then switches to purple during further progress. The color changes to purple after the first time the progress bar stands still for a short moment.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I can't reliably reproduce this.

The color change occurs in BrowserApp.onTabChanged for both LOCATION_CHANGE and SELECTED events.

I didn't realize this was a fall-through and originally intended this to be for SELECTED events only. What's probably happening is a page starts loading in normal browsing, we open a new private tab, start loading a page, and we receive the LOCATION_CHANGE event for the normal browsing tab, changing the color of the progress bar to normal browsing until the LOCATION_CHANGE event occurs for private browsing.

To provide extra information, I initially thought, and then ruled out, that because the event happens asynchronously (via notifyListeners which places the Runnable on the the UiThread), it's possible there is a moment between the time when the tab is selected in Gecko and the UI updates (meaning the old progress bar is displayed), but then the toolbar text would be the old toolbar text (and I'd imagine the toolbar background color would be different as well).

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1184708 - Set progress view private mode when visibility is changed. r=mhaigh

Bug 1184708 - Set progress view private mode when visibility is changed. r=mhaigh

Comment 3

[Martyn Haigh (:mhaigh)]

Comment on attachment 8637610 [details]
MozReview Request: Bug 1184708 - Set progress view private mode when visibility is changed. r=mhaigh

https://reviewboard.mozilla.org/r/13951/#review12779

Seems sane to me :)

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/a2f1be1d0d5984ea94044a810299a2a91418a8c4
changeset:  a2f1be1d0d5984ea94044a810299a2a91418a8c4
user:       Michael Comella <[e-mail]>
date:       Wed Jul 22 19:03:47 2015 -0700
description:
Bug 1184708 - Set progress view private mode when visibility is changed. r=mhaigh

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a2f1be1d0d59