1184716 - [Bugzilla Lite] 2.5 Visual Polish

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect, P1)

Description

[Amy Lee [:amylee] UX]

Hi Dale, 

I've attached visual edits to Bugzilla Lite 2.5. There are 4 pages to the PDF.

Thanks!

Comment 1

[Amy Lee [:amylee] UX]

Attachment: Edits_BugzillaLite_v1.pdf

Comment 2

[Cynthia Tang [:cynthiatang]]

Hi Amy,
I have a question for the user story. Does Bugzilla Lite allow the end user to add attachments in Edits mode? Thanks.

Comment 3

[Amy Lee [:amylee] UX]

(In reply to Cynthia Tang [:cynthiatang] from comment #2)
> Hi Amy,
> I have a question for the user story. Does Bugzilla Lite allow the end user
> to add attachments in Edits mode? Thanks.

Hi Cynthia, 

I'm not clear on what you mean by Edits Mode. Also deferring to Jacqueline who did the UX.

Comment 4

[Cynthia Tang [:cynthiatang]]

Hi Amy, thanks for you help!

Hi Jacqueline, 
Does Bugzilla Lite allow the end use to add attachments for the bug that he filed in past time? Thank you.

There is a scenario. I used Bugzilla Lite to file a bug last week. Today I'd like to add more attachments for the bug that I filed.

Comment 5

[Dale Harvey (:daleharvey)]

> I have a question for the user story. Does Bugzilla Lite allow the end user 
> to add attachments in Edits mode? Thanks.

Cynthia, uploading attachments is a new feature we do want to support, its being tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1177286 and not part of this bug, cheers

Comment 6

[Cynthia Tang [:cynthiatang]]

Thank you.

Comment 7

[Dale Harvey (:daleharvey)]

Ok, there are fixed with r=amy @ https://github.com/mozilla-b2g/bzlite/commit/41078dee9eca2375b0c2cb4be69cda3da3a82946

They are all live now so you can play about and file follow ups, individual follow up will probably be easier from now on. Thanks :)

Commented on the changes below since not all of them are possible / bzlite's responsibility.

> 1. Left/right/top margins should be 15px on all screens - Please adjust text and hairline dividers to have a 15px margin.

I should have them all now, the spacing on the dashboard looks off to me so if theres something needing changed there can you say?
 
> 2. Bottom toolbar – Remove top hairline in  bottom toolbar

Done

3. bottom toolbar – blue bar highlight should slide to selected state (see hacker place tab bar 
for reference).

Hackerplace gets this from using web components which we arent, so filed a follow up for that - https://bugzilla.mozilla.org/show_bug.cgi?id=1192364

4. Bug Page - For “Status selector are we able to use the new selector style? (see http://gaiacomponents.github.io/gaia-components/ and go to Value Select -> Select) + 5. Bug Page - Can we remove the gradient in the “Status” selector and style it based on the text eld below and make the text bigger? There should be more spacing between the selector box and “Status” as well.

I added a 1.5rem margin between them, https://bugzilla.mozilla.org/show_bug.cgi?id=944382 is filed to fix the styling which is a fairly large amount of work

6. Bug Page - “Take Bug” conrmation screen is outdated. Can we use the newer gail-components conrm pop-up? (see http://gaia-components.github.io/gaia-components/ and go to Dialog -> Conrm) 

This dialog is shown by the system app, would need a system app visual update, I believe last time it was brought up UX/Product said that wasnt happening?

1. Search Bar - Can we use the gaia-component search bar here? 

Again no components, but copied across the styling

2. Header icons – On press and hold, there is a faint blue box around each icon. This should be 
removed.

Good eye that was really hard to see, fixed

1. Please remove blue box around on pressed state

Done

2. Search Bar - Can we use the gaia-component 
search bar here? The blue underline shouldn’t 
curve 

Copied styling from component

1. Loading spinner - Please use the gaia-component 
horizontal loading bar. This should sit right under the 
header. 

I switched both the bug page and the dashboard too use the progress bar style loader

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

Since verifyme was added, I attempted to verify this with limited information from the PDF at comment 1.

On the PDF document:
Page 1 no. 1: Verified
Page 1 no. 2: Verified
Page 1 no. 3: Not implemented. bug 1192364 was filed for follow up
Page 1 no. 4: Not implemented. bug 944382 for follow up
Page 1 no. 5: More spacing added verified. The rest are not implemented and bug 944382 tracks those
Page 1 no. 6: Not implemented. According to comment 7 it's not going to be implemented.

Page 2 no. 1: I can't find anywhere on http://gaia-components.github.io/gaia-components/ that demonstrates a search bar style so unable to verify.
Page 2 no. 2: Verified; although I found if I tap and hold on a header icon, and move my finger away, the icon stays as gray-colored as if it's still being pressed. I'm not sure if this is expected.

Page 3 no. 1: Verified
Page 3 no. 2: Again I can't find a search bar example on Gaia component. But the blue underline isn't curved anymore.

Page 4 no. 1: Verified.

Comment 9

[Pi Wei Cheng [:piwei] (inactive)]

Verified on:
Device: Aries 2.5
BuildID: 20150820012109
Gaia: 89e0096a3de0378e3eda77e6a2a0bb5ca03eb8bb
Gecko: 29b2df16e961fbe9a379362ecba6f888d1754bc3
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0