Closed Bug 1184760 Opened 6 years ago Closed 6 years ago

Avoid opening TOS and privacy links from Account settings in a new tab.

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: vivek, Assigned: vivek)

Details

(Whiteboard: [lang=java])

Attachments

(1 file)

TOS and Privacy statement must switch to existing tab if available, else load in a new tab.
This is a nice to have feature.
Summary: Avoid opening TOS and privacy links in a new tab. → Avoid opening TOS and privacy links from Account settings in a new tab.
Bug 1184760 - Load TOS and privacy links in exising tabs  r?nalexander
Attachment #8663450 - Flags: review?(nalexander)
(In reply to Vivek Balakrishnan[:vivek] from comment #0)
> TOS and Privacy statement must switch to existing tab if available, else
> load in a new tab.
> This is a nice to have feature.

I'm not familiar with this.  I don't want to take a user's tab and re-direct it, ever.  If we could take just an about:accounts tab, /maybe/.  Overall, this just isn't worth the effort.  Can you comment?  (Aalso, there's a typo (exising) in the bug comment.)
Flags: needinfo?(vivekb.balakrishnan)
Attachment #8663450 - Flags: review?(nalexander)
Comment on attachment 8663450 [details]
MozReview Request: Bug 1184760 - Load TOS and privacy links in exising tabs  r?nalexander

https://reviewboard.mozilla.org/r/19813/#review17863
As agreed over irc with Nick and Comella, that this is not a frequent user action and it is not worth the effort. The relevant irc conversation follows

Sep 22 02:12:19 <mcomella>	vivek: I'm not familiar with the LOAD action off-hand, but before I spend time investigating, I'm curious why you would load it in the current tab?
Sep 22 02:12:31 <mcomella>	vivek: I'd think you'd want to open a new tab to prevent the sure losing data
Sep 22 02:12:44 <bc>	snorp: sorry. that was mcmanus
Sep 22 02:13:10 <snorp>	nice! 
Sep 22 02:13:16 <vivek>	mcomella: yup,thats my intention. The LOAD action is wrong. Ideally I want to switch to an existing tab or load in new tab
Sep 22 02:13:42 *	mwargers has quit (Connection closed)
Sep 22 02:14:16 *	arlen has quit (Quit: exit)
Sep 22 02:14:57 <mcomella>	vivek: What existing tab would there be to switch to?
Sep 22 02:15:53 <nalexander>	mcomella: well, if you did this multiple times, or read ToS and then Privacy, for example.
Sep 22 02:15:59 <vivek>	mcomella: If the user has a tab for that url, then switch to that tab instead of loading it in a new tab
Sep 22 02:16:31 <mcomella>	vivek: If this doesn't happen frequently, I wouldn't spend too much time on – the user can close an extra tab.
Sep 22 02:16:41 <mcomella>	vivek: But that being said, I think you can do what you want to do with applicationId, as you asked
Sep 22 02:16:43 <nalexander>	mcomella: yeah, that's my take.
Sep 22 02:16:49 nalexander naf3ts- nerd_bloke nical-irccloud nicksydney noida not_gavin nyuszika7h 
Sep 22 02:17:58 <vivek>	nalexander, mcomella : I agree it is not worth effort, should I mark that bug as wont fix?
Sep 22 02:18:01 *	sergejk has quit (Ping timeout: 121 seconds)
Sep 22 02:18:18 <nalexander>	vivek: if you would, with a discussion of what was agreed.
Sep 22 02:18:42 <vivek>	nalexander: okay
Sep 22 02:18:48 <nalexander>	vivek: thanks.
Sep 22 02:18:53 <nalexander>	mcomella: you too!
Flags: needinfo?(vivekb.balakrishnan)
Marking this bug as Wont fix
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.