Closed
Bug 1184775
Opened 10 years ago
Closed 10 years ago
Fix missing semicolons and enable the ESLint 'semi' rule
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
[~/src/treeherder]$ grunt checkjs
Running "eslint:target" (eslint) task
ui/js/compareperf.js
153:99 error Missing semicolon semi
155:105 error Missing semicolon semi
171:51 error Missing semicolon semi
184:71 error Missing semicolon semi
295:53 error Missing semicolon semi
ui/js/graphs.js
56:54 error Missing semicolon semi
171:54 error Missing semicolon semi
228:57 error Missing semicolon semi
335:56 error Missing semicolon semi
339:65 error Missing semicolon semi
352:74 error Missing semicolon semi
439:5 error Missing semicolon semi
449:5 error Missing semicolon semi
457:105 error Missing semicolon semi
470:31 error Missing semicolon semi
473:28 error Missing semicolon semi
474:30 error Missing semicolon semi
507:28 error Missing semicolon semi
535:24 error Missing semicolon semi
604:5 error Missing semicolon semi
607:41 error Missing semicolon semi
609:5 error Missing semicolon semi
622:93 error Missing semicolon semi
623:47 error Missing semicolon semi
627:11 error Missing semicolon semi
628:54 error Missing semicolon semi
657:13 error Missing semicolon semi
755:54 error Missing semicolon semi
759:8 error Missing semicolon semi
826:89 error Missing semicolon semi
829:7 error Missing semicolon semi
ui/js/perf.js
103:74 error Missing semicolon semi
146:20 error Missing semicolon semi
168:3 error Missing semicolon semi
181:3 error Missing semicolon semi
357:84 error Missing semicolon semi
427:12 error Missing semicolon semi
ui/js/perfapp.js
53:4 error Missing semicolon semi
ui/js/controllers/settings.js
10:2 error Missing semicolon semi
ui/js/directives/perf/compare.js
15:5 error Missing semicolon semi
25:5 error Missing semicolon semi
ui/js/directives/treeherder/main.js
88:9 error Missing semicolon semi
107:9 error Missing semicolon semi
118:37 error Missing semicolon semi
119:47 error Missing semicolon semi
121:5 error Missing semicolon semi
130:76 error Missing semicolon semi
138:5 error Missing semicolon semi
155:5 error Missing semicolon semi
166:49 error Missing semicolon semi
202:13 error Missing semicolon semi
210:5 error Missing semicolon semi
226:54 error Missing semicolon semi
231:86 error Missing semicolon semi
252:5 error Missing semicolon semi
ui/js/models/error.js
41:5 error Missing semicolon semi
ui/js/services/main.js
81:5 error Missing semicolon semi
84:19 error Missing semicolon semi
87:22 error Missing semicolon semi
129:18 error Missing semicolon semi
162:5 error Missing semicolon semi
218:51 error Missing semicolon semi
220:5 error Missing semicolon semi
✖ 63 problems (63 errors, 0 warnings)
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8634990 -
Flags: review?(wlachance)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8634990 [details] [review]
Fix missing semicolons and enable the ESLint 'semi' rule
lgtm!
Attachment #8634990 -
Flags: review?(wlachance) → review+
|
||
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/b32bd9d1f2963a6e1845a371064de5248d5ac739
Bug 1184775 - Add missing semicolons in JS files
https://github.com/mozilla/treeherder/commit/d6dbaefb7e264993649dafbae0142942160daf29
Bug 1184775 - ESLint: Enable the 'semi' rule
semi: "require or disallow use of semicolons instead of ASI"
https://github.com/mozilla/treeherder/commit/61fe06b51ae09afdb80540d36e0b7f4ee060f8b9
Merge pull request #780 from mozilla/eslint-semi
Bug 1184775 - Fix missing semicolons and enable the ESLint 'semi' rule
|
|
||
Comment 4•10 years ago
|
||
This sort of thing is better to merge sooner than later, so I did so.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•