1184792 - OpenH264: crash [@WelsCopy16x16_sse2]

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: call_stack.txt

Looks like potential stack corruption.

Comment 1

[Tyson Smith [:tsmith]]

Attachment: test_case.264

Comment 2

[Haibo Zhu]

This bug has been fixed in the latest version of openh264 master branch.

Comment 3

[Tyson Smith [:tsmith]]

Fixed. Verified with https://github.com/cisco/openh264/commit/f30ad4e512e84a1376f5223f9a450c075e0b0df9

Comment 4

[Daniel Veditz [:dveditz]]

Tyson: does this crash affect the currently-shipping 1.4? if you've only tested recent dev versions please also test the shipping one so we know if we need to release an advisory or not.

Comment 5

[Tyson Smith [:tsmith]]

This does not seem to affect the v1.4-Firefox38 branch.

Tested with https://github.com/cisco/openh264/commit/0bb2131291b1e1a974777c79fcff09c233f63229

Comment 6

[Tyson Smith [:tsmith]]

(In reply to Tyson Smith [:tsmith] from comment #5)
> This does not seem to affect the v1.4-Firefox38 branch.
> 
> Tested with
> https://github.com/cisco/openh264/commit/
> 0bb2131291b1e1a974777c79fcff09c233f63229

I should say I could not reproduce this issue with the attached test case.

Comment 7

[karina]

This doesn't affect the v1.4-Firefox38 branch.

Comment 8

[Al Billings [:abillings - ex-MoCo]]

Folks, can you resolve these bugs when they're fixed? Otherwise, they linger.